Skip to content

issues Search Results · repo:tabatkins/parse-css language:JavaScript

Filter by

28 results
 (82 ms)

28 results

intabatkins/parse-css (press backspace or delete to remove)

tabatkins/parse-css
Parsing nested rules is considerably slower than parsing top-level rules

I d like to preface this by saying that I am quite new to CSS parsing, so I could be overlooking something very obvious; apologies if that s the case. And I am not sure if this is the right place to ask ...
  • soitchu
  • 2
  • Opened 
    on Aug 20, 2024
  • #60

tabatkins/parse-css
Duplicate test case

The following two tests are identical: https://github.com/tabatkins/parse-css/blob/c7859c41887409c533beed36956b7976ea0144b4/tests.js#L331-L335 https://github.com/tabatkins/parse-css/blob/c7859c41887409c533beed36956b7976ea0144b4/tests.js#L336-L340 ...
  • amn
  • 1
  • Opened 
    on May 11, 2024
  • #58

tabatkins/parse-css
`escapeIdent` seems to be a bit too eager

https://github.com/tabatkins/parse-css/blob/6f8f9d5381bbbc3859b8d86718376f53c148ce21/parse-css.js#L757 escapeIdent( --foo ) // \\--foo
  • romainmenke
  • Opened 
    on Jun 24, 2023
  • #50

tabatkins/parse-css
Some token types where removed but not entirely cleaned up

https://github.com/tabatkins/parse-css/commit/aa45c3c1a4dddb3ff9b891101a6843f04e1849bc ReferenceError: SubstringMatchToken is not defined These are still in use in some places : https://github.com/tabatkins/parse-css/blob/main/parse-css.js#L174 ...
  • romainmenke
  • Opened 
    on May 24, 2023
  • #48

tabatkins/parse-css
`HashToken.type` is incorrect when it is an `id`

https://github.com/tabatkins/parse-css/blob/df2089c6e2f067e0edef88e27906d333baffdab9/parse-css.js#L155 This clashes with the type that all tokens have and that distinguishes them. Other HashToken instances ...
  • romainmenke
  • 3
  • Opened 
    on May 23, 2023
  • #47

tabatkins/parse-css
`escapeIdentCode` doesn't exist.

https://github.com/tabatkins/parse-css/blob/998aced565ad5d658196b557e255effaa7d4abe8/parse-css.js#L801 ReferenceError: escapeIdentCode is not defined
  • romainmenke
  • 2
  • Opened 
    on May 23, 2023
  • #46

tabatkins/parse-css
parser or example.html issues with nesting at-rules

The parser token and JSON results appear different to me when parsing nesting at-rules. I’m unsure if the parser itself has issues parsing nesting at-rules, or if this is a limitation within the example.html ...
  • jonathantneal
  • 3
  • Opened 
    on Sep 24, 2019
  • #44

tabatkins/parse-css
Wrong end character in consumeTheRemnantsOfABadURL

while(consume()) { if(code == 0x2d || eof()) { return; According to the spec this should be U+0029 RIGHT PARENTHESIS ()) rather than 0x2d (-). Thanks for the code.
  • danfickle
  • 1
  • Opened 
    on May 24, 2017
  • #43

tabatkins/parse-css
Throw parse errors instead of just logging them to console

This way the parser could be used to validate properties and attributes, e.g.: let isValidStyleAttributeValue = (value) = { try { CSSParser.parseAListOfDeclarations(value.trim()); } catch ...
  • jarek-foksa
  • 3
  • Opened 
    on Aug 4, 2016
  • #41

tabatkins/parse-css
Strings with different starting and ending quote should be treated as invalid

Calling tokenize( a ) should return BAD_STRING rather than STRING token, at least this is how I understand the grammar.
  • jarek-foksa
  • 1
  • Opened 
    on Aug 3, 2016
  • #40
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Press the
/
key to activate the search input again and adjust your query.
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Press the
/
key to activate the search input again and adjust your query.
Issue search results · GitHub