Skip to content

GrantConfigurator should accept League\OAuth2\Server\Grant\GrantTypeInterface #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
TLG-Gildas opened this issue Mar 21, 2025 · 1 comment · May be fixed by #227
Open

GrantConfigurator should accept League\OAuth2\Server\Grant\GrantTypeInterface #225

TLG-Gildas opened this issue Mar 21, 2025 · 1 comment · May be fixed by #227

Comments

@TLG-Gildas
Copy link

GrantConfigurator only accepts custom grants implementing the League\Bundle\OAuth2ServerBundle\AuthorizationServer\GrantTypeInterface interface. However, if we want to use a custom grant from a library designed for league/oauth2-server and not for league/oauth2-server-bundle, we must create a new class inheriting from the library's grant in order to add the bundle interface.

It would be desirable for GrantConfigurator to also accept the basic league/oauth2-server interface.
In this case, to configure the access token TTL, I imagine it would be possible to use an attribute associated with the league.oauth2_server.authorization_server.grant tag.

What do you think about this?
@chalasr
Copy link
Member

chalasr commented Mar 22, 2025

Bundles should contain as less logic as possible 👍 If one can come up with something that allows removing this child interface while keeping the same level of DX and design, I'd be happy.

TLG-Gildas added a commit to TLG-Gildas/oauth2-server-bundle that referenced this issue Mar 23, 2025
@TLG-Gildas
fix: thephpleague#225: GrantConfigurator should accept League\OAuth2\…
f4ee26f 
…Server\Grant\GrantTypeInterface
@TLG-Gildas TLG-Gildas linked a pull request Mar 23, 2025 that will close this issue
Open
TLG-Gildas added a commit to TLG-Gildas/oauth2-server-bundle that referenced this issue Mar 23, 2025
@TLG-Gildas
fix: thephpleague#225: GrantConfigurator should accept League\OAuth2\…
5a21ac9 
…Server\Grant\GrantTypeInterface
TLG-Gildas added a commit to TLG-Gildas/oauth2-server-bundle that referenced this issue Mar 23, 2025
@TLG-Gildas
fix: thephpleague#225: coding standards
67336d9
TLG-Gildas added a commit to TLG-Gildas/oauth2-server-bundle that referenced this issue Mar 23, 2025
@TLG-Gildas
fix: thephpleague#225: update documentation to add usage of Autoconfi…
c40a1a3 
…gureTag attribute
TLG-Gildas added a commit to TLG-Gildas/oauth2-server-bundle that referenced this issue Mar 24, 2025
@TLG-Gildas
fix: thephpleague#225: register for autoconfiguration of League\OAuth…
1ba3aa7 
…2\Server\Grant\GrantTypeInterface
TLG-Gildas added a commit to TLG-Gildas/oauth2-server-bundle that referenced this issue Mar 31, 2025
@TLG-Gildas
fix: thephpleague#225: GrantConfigurator should accept League\OAuth2\…
c88895f 
…Server\Grant\GrantTypeInterface
TLG-Gildas added a commit to TLG-Gildas/oauth2-server-bundle that referenced this issue Mar 31, 2025
@TLG-Gildas
fix: thephpleague#225: coding standards
0ffa806
TLG-Gildas added a commit to TLG-Gildas/oauth2-server-bundle that referenced this issue Mar 31, 2025
@TLG-Gildas
fix: thephpleague#225: update documentation to add usage of Autoconfi…
b44cbb6 
…gureTag attribute
TLG-Gildas added a commit to TLG-Gildas/oauth2-server-bundle that referenced this issue Mar 31, 2025
@TLG-Gildas
fix: thephpleague#225: register for autoconfiguration of League\OAuth…
3718242 
…2\Server\Grant\GrantTypeInterface
TLG-Gildas added a commit to TLG-Gildas/oauth2-server-bundle that referenced this issue Mar 31, 2025
@TLG-Gildas
fix: thephpleague#225: coding standard & stan
41caa90
TLG-Gildas added a commit to TLG-Gildas/oauth2-server-bundle that referenced this issue Mar 31, 2025
@TLG-Gildas
fix: thephpleague#225: revert autoconfiguration of League\OAuth2\Serv…
0975ab8 
…er\Grant\GrantTypeInterface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@chalasr @TLG-Gildas