-
Notifications
You must be signed in to change notification settings - Fork 15
[FF-7] Migrate Tabs #4768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[FF-7] Migrate Tabs #4768
Conversation
🦋 Changeset detectedLatest commit: 2a3da7c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@toptal-bot run package:alpha-release |
@toptal-bot run package:alpha-release |
Your alpha package is ready 🎉 |
@toptal-bot run package:alpha-release |
Your alpha package is ready 🎉 |
@toptal-bot run package:alpha-release |
Your alpha package is ready 🎉 |
@dmaklygin I know this is a draft but https://github.com/toptal/staff-portal/pull/14453 you requested to review this too. Seems in this story the active tab is not working anymore |
Could you please share a link to temploy. |
@dmaklygin but the story in this PR is different please check the link and notice the change on |
Yeah, I've checked the stories and confirm, the changes are intentional. |
The left side of the comparison belongs to a previous version. The right side – to the new one |
My apologies for the confusion 🙈 |
FF-7
Description
Migrate tabs to Mui/Base
How to test
Screenshots
Development checks
picasso-tailwind-merge
requires major update (check itsREADME.md
)props
in component with documentationexamples
for componentBreaking change
PR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping for reviewsPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?