Skip to content

Fix: More on-screen slides in carousel #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2025

Conversation

vr-varad
Copy link
Contributor

Notes for Reviewers

This PR fixes #437

Signed commits

  • Yes, I signed my commits.

Signed-off-by: vr-varad <varadgupta21@gmail.com>
Copy link

netlify bot commented Mar 24, 2025

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit 3c7a9e2
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-pegasus-b0ce81/deploys/67ea6d120a83cb00081a818d
😎 Deploy Preview https://deploy-preview-465--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vr-varad
Copy link
Contributor Author

blob.1.mp4

@vr-varad
Copy link
Contributor Author

Done @vishalvivekm

Signed-off-by: vr-varad <varadgupta21@gmail.com>
Copy link
Contributor

@zihanKuang zihanKuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, the changes look good to me. 👍

@vishalvivekm
Copy link
Contributor

@vr-varad
Copy link
Contributor Author

Should I drop it down to one as screen size decreases?@vishalvivekm

@vishalvivekm
Copy link
Contributor

Should I drop it down to one as screen size decreases?@vishalvivekm

that would be ideal, to just keep one in mobile width

@miacycle
Copy link
Contributor

@vr-varad @vishalvivekm is this effort still underway?

@leecalcote
Copy link
Member

@vr-varad, are you still tracking this?

@leecalcote leecalcote merged commit 7ab9dec into layer5io:master Apr 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[video] more on-screen slides in carousel
5 participants