Skip to content

Remove fluentd and associated plugins from Azure Linux 3.0 #13478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025

Conversation

jslobodzian
Copy link
Collaborator

@jslobodzian jslobodzian commented Apr 18, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Fluentd is not supported in Azure Linux 3.0 and was not intended to be shipped with AZL 3.0. Only FluentBit is supported. This PR removes fluentd and all associated plugins.

Does this affect the toolchain?

NO

@jslobodzian jslobodzian requested review from a team as code owners April 18, 2025 14:10
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging specs-extended PR to fix SPECS-EXTENDED Tools 3.0 PRs Destined for 3.0 labels Apr 18, 2025
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we might have targeted the wrong base-branch.
Was it supposed to go to 3.0-dev ?

@jslobodzian jslobodzian changed the base branch from 3.0 to 3.0-dev April 21, 2025 14:40
@jslobodzian
Copy link
Collaborator Author

It seems we might have targeted the wrong base-branch. Was it supposed to go to 3.0-dev ?

yes. Good catch.

@microsoft-github-policy-service microsoft-github-policy-service bot added the 3.0-dev PRs Destined for AzureLinux 3.0 label Apr 21, 2025
@anphel31
Copy link
Member

I think we should verify this with a full build. Started one: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=793339&view=results

@jslobodzian jslobodzian merged commit 0568651 into 3.0-dev Apr 23, 2025
14 checks passed
@jslobodzian jslobodzian deleted the joslobo/remove-fluentd-plugins branch April 23, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 3.0 PRs Destined for 3.0 Packaging specs-extended PR to fix SPECS-EXTENDED Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants