Skip to content

Onboarding Omni_Math Benchmark #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 50 commits into
base: main
Choose a base branch
from
Open

Conversation

vidhishanair
Copy link
Collaborator

This PR adds user configs, answer extractors and templates for the omni math benchmark.

@vidhishanair vidhishanair requested a review from lchen001 March 11, 2025 04:40
Copy link
Collaborator

@lchen001 lchen001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall. I only have a few minor suggestions.

"path": "KbsdJames/Omni-MATH",
"split": "test",
"transform": SequenceTransform([
#SamplerTransform(sample_count=20, random_seed=99),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove all sample transformers if the config is considered stable?

ColumnRename(name_mapping={"n_output_tokens":"gen_solution_n_output_tokens",
"usage": "gen_solution_usage",
"is_valid": "gen_solution_is_valid"}),
# SamplerTransform(sample_count=5, random_seed=99),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same sampler transformer issue here

"split": "test",
"transform": SequenceTransform([
#SamplerTransform(sample_count=20, random_seed=99),
MultiplyTransform(n_repeats=1),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants