-
Notifications
You must be signed in to change notification settings - Fork 21
Onboarding Omni_Math Benchmark #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
eureka_ml_insights/prompt_templates/omni_math_templates/omni_math_gpt_eval.jinja
Show resolved
Hide resolved
…eka-ml-insights into vidhisha/omni_math
…eka-ml-insights into vidhisha/omni_math
…eka-ml-insights into vidhisha/omni_math
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall. I only have a few minor suggestions.
"path": "KbsdJames/Omni-MATH", | ||
"split": "test", | ||
"transform": SequenceTransform([ | ||
#SamplerTransform(sample_count=20, random_seed=99), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove all sample transformers if the config is considered stable?
ColumnRename(name_mapping={"n_output_tokens":"gen_solution_n_output_tokens", | ||
"usage": "gen_solution_usage", | ||
"is_valid": "gen_solution_is_valid"}), | ||
# SamplerTransform(sample_count=5, random_seed=99), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same sampler transformer issue here
"split": "test", | ||
"transform": SequenceTransform([ | ||
#SamplerTransform(sample_count=20, random_seed=99), | ||
MultiplyTransform(n_repeats=1), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need this?
This PR adds user configs, answer extractors and templates for the omni math benchmark.