Skip to content

[ENG-8084] Feature/upgrade adding contributor notifications #11189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 27 commits into
base: refactor-notifications
Choose a base branch
from

Conversation

bodintsov
Copy link
Contributor

Purpose

Notifications to be created with the normal request context using the new model.

Changes

TBD

QA Notes

TBD

Documentation

TBD

Side Effects

TBD

Ticket

https://openscience.atlassian.net/browse/ENG-8084

Johnetordoff and others added 16 commits May 21, 2025 10:42
…cience/osf.io into add-new-notifications-data-model

* 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io:
  [ENG-7965] Add v2 email token confirmation endpoints (CenterForOpenScience#11139)
…cience/osf.io into add-new-notifications-data-model

* 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io:
  fix issue where not having any external identities caused a 500
…cience/osf.io into add-new-notifications-data-model

* 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io:
  [ENG-7966] Add "collected-in" relationship for Nodes (CenterForOpenScience#11140)
…cience/osf.io into add-new-notifications-data-model

* 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io:
  fix issue where trying another already confirmed email threw an uncaught exception (CenterForOpenScience#11161)
  [ENG-8148] Add ArtifactOutcome in annotations to linked nodes  (CenterForOpenScience#11158)
…OpenScience/osf.io into add-new-notifications-data-model

* 'refactor-notifications' of https://github.com/CenterForOpenScience/osf.io:
  flake8
  fixed tests
  remove quickfiles
  update mails mock
  Update send_mail mocks
  Clean up tests
  Clean up tests
  Clean up imports
  Remove Meetings, Comments and OSF Groups Notifications
  remove osf groups
  remove osf groups
  remove osf groups
  remove osf groups
  remove osf groups

# Conflicts:
#	tests/test_notifications.py
…cience/osf.io into add-new-notifications-data-model

* 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io:
  Update hybrid values for new workflow check (CenterForOpenScience#11166)
…OpenScience/osf.io into add-new-notifications-data-model

* 'refactor-notifications' of https://github.com/CenterForOpenScience/osf.io:
  ignore Django maintenance state outside block
…OpenScience/osf.io into add-new-notifications-data-model

* 'refactor-notifications' of https://github.com/CenterForOpenScience/osf.io:
  fixed bug with contributors
  remove superfluildous `groups` from serializer
  fix new and noteworth nodes bug going to Sentry
…versions with _v1 (CenterForOpenScience#11154)

## Purpose
do not mint _v1 doi if legacy one exists

## Changes
- make sure that CrossrefClient works well with legacy DOIs
- don't send request to crossref when check_crossref_dois if no DOIs were selected
- check only published preprints when mint_doi_on_crossref_fail

## Ticket
https://openscience.atlassian.net/browse/ENG-7870
…enterForOpenScience#11169)

## Purpose
When user adds a component to a node that has addons with files and registers it, the node doesn't have any archived files. It happens because the child nodes are the first ones to be registered and if a child doesn't have any addons, this empty list would be saved in `request.gv_addons` attribute that is reused for all other parents and children to avoid making redundant requests to GV. However each child and parent may have its own collection of addons.

## Changes
Removed caching

## QA Notes
Would be nice to test what happens when a child node has addons with files, but its parent hasn't. Will the parent inherit archived addons files or not?

## Ticket
https://openscience.atlassian.net/browse/ENG-8048
## Purpose
`_get_addon_from_gv` iterates through None when service is not found in `_get_addons_from_gv_without_caching`

## Changes
Replace None by an empty list
Copy link
Contributor

@Johnetordoff Johnetordoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you did the correct objective, but I notice failing unittests, please fix them and re-submit.

@bodintsov bodintsov force-pushed the feature/upgrade-adding-contributor-notifications branch from 73f2ed8 to d30f868 Compare June 24, 2025 09:35
Johnetordoff and others added 11 commits June 25, 2025 09:16
…cience/osf.io into add-new-notifications-data-model

* 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io:
  fixed None issue when iterate (CenterForOpenScience#11192)
  [ENG-8048] Remove caching to avoid incorrect results for ascendants (CenterForOpenScience#11169)
  [ENG-7870] Crossref DOIs not minting with _v1, OSF is displaying DOI versions with _v1 (CenterForOpenScience#11154)
  Update changelog and package.json
  [ENG-8145] [ENG-8147] Manual DOI and GUID for Preprints & Registrations - BE (CenterForOpenScience#11174)
…ce/revert-11192-fix/ENG-8048-none

Revert "[ENG-8048_2] fixed None issue during iteration"
…ce/revert-11169-fix/ENG-8048

Revert "[ENG-8048] Remove caching to avoid incorrect results for ascendants"
…cience/osf.io into add-new-notifications-data-model

* 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io:
  Revert "[ENG-8048] Remove caching to avoid incorrect results for ascendants (…"
  Revert "fixed None issue when iterate (CenterForOpenScience#11192)"
@bodintsov bodintsov force-pushed the feature/upgrade-adding-contributor-notifications branch from d30f868 to dc63745 Compare July 7, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants