[ENG-8084] Feature/upgrade adding contributor notifications #11189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cience/osf.io into add-new-notifications-data-model * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: [ENG-7965] Add v2 email token confirmation endpoints (CenterForOpenScience#11139)
…cience/osf.io into add-new-notifications-data-model * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: fix issue where not having any external identities caused a 500
…cience/osf.io into add-new-notifications-data-model * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: [ENG-7966] Add "collected-in" relationship for Nodes (CenterForOpenScience#11140)
…cience/osf.io into add-new-notifications-data-model * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: fix issue where trying another already confirmed email threw an uncaught exception (CenterForOpenScience#11161) [ENG-8148] Add ArtifactOutcome in annotations to linked nodes (CenterForOpenScience#11158)
…OpenScience/osf.io into add-new-notifications-data-model * 'refactor-notifications' of https://github.com/CenterForOpenScience/osf.io: flake8 fixed tests remove quickfiles update mails mock Update send_mail mocks Clean up tests Clean up tests Clean up imports Remove Meetings, Comments and OSF Groups Notifications remove osf groups remove osf groups remove osf groups remove osf groups remove osf groups # Conflicts: # tests/test_notifications.py
…cience/osf.io into add-new-notifications-data-model * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: Update hybrid values for new workflow check (CenterForOpenScience#11166)
…OpenScience/osf.io into add-new-notifications-data-model * 'refactor-notifications' of https://github.com/CenterForOpenScience/osf.io: ignore Django maintenance state outside block
…OpenScience/osf.io into add-new-notifications-data-model * 'refactor-notifications' of https://github.com/CenterForOpenScience/osf.io: fixed bug with contributors remove superfluildous `groups` from serializer fix new and noteworth nodes bug going to Sentry
…versions with _v1 (CenterForOpenScience#11154) ## Purpose do not mint _v1 doi if legacy one exists ## Changes - make sure that CrossrefClient works well with legacy DOIs - don't send request to crossref when check_crossref_dois if no DOIs were selected - check only published preprints when mint_doi_on_crossref_fail ## Ticket https://openscience.atlassian.net/browse/ENG-7870
…enterForOpenScience#11169) ## Purpose When user adds a component to a node that has addons with files and registers it, the node doesn't have any archived files. It happens because the child nodes are the first ones to be registered and if a child doesn't have any addons, this empty list would be saved in `request.gv_addons` attribute that is reused for all other parents and children to avoid making redundant requests to GV. However each child and parent may have its own collection of addons. ## Changes Removed caching ## QA Notes Would be nice to test what happens when a child node has addons with files, but its parent hasn't. Will the parent inherit archived addons files or not? ## Ticket https://openscience.atlassian.net/browse/ENG-8048
## Purpose `_get_addon_from_gv` iterates through None when service is not found in `_get_addons_from_gv_without_caching` ## Changes Replace None by an empty list
Johnetordoff
requested changes
Jun 23, 2025
bodintsov
force-pushed
the
feature/upgrade-adding-contributor-notifications
branch
from
73f2ed8 to
d30f868
Compare
…cience/osf.io into add-new-notifications-data-model * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: fixed None issue when iterate (CenterForOpenScience#11192) [ENG-8048] Remove caching to avoid incorrect results for ascendants (CenterForOpenScience#11169) [ENG-7870] Crossref DOIs not minting with _v1, OSF is displaying DOI versions with _v1 (CenterForOpenScience#11154) Update changelog and package.json [ENG-8145] [ENG-8147] Manual DOI and GUID for Preprints & Registrations - BE (CenterForOpenScience#11174)
This reverts commit 5c918fa.
…ce/revert-11192-fix/ENG-8048-none Revert "[ENG-8048_2] fixed None issue during iteration"
…ndants (…" This reverts commit 7d752ac.
…ce/revert-11169-fix/ENG-8048 Revert "[ENG-8048] Remove caching to avoid incorrect results for ascendants"
…cience/osf.io into add-new-notifications-data-model * 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io: Revert "[ENG-8048] Remove caching to avoid incorrect results for ascendants (…" Revert "fixed None issue when iterate (CenterForOpenScience#11192)"
…OpenScience/osf.io into add-new-notifications-data-model * 'refactor-notifications' of https://github.com/CenterForOpenScience/osf.io:
bodintsov
force-pushed
the
feature/upgrade-adding-contributor-notifications
branch
from
d30f868 to
dc63745
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Notifications to be created with the normal request context using the new model.
Changes
TBD
QA Notes
TBD
Documentation
TBD
Side Effects
TBD
Ticket
https://openscience.atlassian.net/browse/ENG-8084