[ENG-8224] Fixed force archive template with registration addons #11210
+3
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjgeiger
changed the base branch from
feature/pbs-25-10
to
feature/pbs-25-13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Product team reported that they cannot force archive registration because of this error:
["7t6qj: Original node zts5b has addons: ['osfstorage', 'wiki', 'github', 'zotero']It happens due to not all configured addons are displayed and selected in the template that is required to archive a registration
For example this registration has zotero and github addons that aren't displayed because we fetch addons from registration, not from it's parent node
Changes
Implicitly fetch addons so that admins shouldn't select them.
Fixed passed params issue
Hide addons from the template (agreed with Blaine)
QA Notes
Nothing was changed in force archive logic, but I encountered one bug related to function params that was fixed as well (as configurable addons have never been displayed, this flow couldn't be really tested by QA, thus force archiver has to be retested with addons)
Ticket
https://openscience.atlassian.net/browse/ENG-8224?atlOrigin=eyJpIjoiZWExYjFiNWJiYzViNGNlMmFhOWQwNDU3NDFmMmJhYjEiLCJwIjoiaiJ9