Skip to content

[ENG-8224] Fixed force archive template with registration addons #11210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: feature/pbs-25-13
Choose a base branch
from

Conversation

ihorsokhanexoft
Copy link
Contributor

@ihorsokhanexoft ihorsokhanexoft commented Jun 30, 2025

Purpose

Product team reported that they cannot force archive registration because of this error:
["7t6qj: Original node zts5b has addons: ['osfstorage', 'wiki', 'github', 'zotero']
It happens due to not all configured addons are displayed and selected in the template that is required to archive a registration

For example this registration has zotero and github addons that aren't displayed because we fetch addons from registration, not from it's parent node
image

Changes

Implicitly fetch addons so that admins shouldn't select them.
Fixed passed params issue
Hide addons from the template (agreed with Blaine)
image

QA Notes

Nothing was changed in force archive logic, but I encountered one bug related to function params that was fixed as well (as configurable addons have never been displayed, this flow couldn't be really tested by QA, thus force archiver has to be retested with addons)

Ticket

https://openscience.atlassian.net/browse/ENG-8224?atlOrigin=eyJpIjoiZWExYjFiNWJiYzViNGNlMmFhOWQwNDU3NDFmMmJhYjEiLCJwIjoiaiJ9

@brianjgeiger brianjgeiger changed the base branch from feature/pbs-25-10 to feature/pbs-25-13 June 30, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant