Separated files and folders in the "Open Recent" sub-menu

[atsrus]

Description

Added additional Defaults key to store recent file paths as well as recent project/folder paths. I 'think' I've understand the contribution guidelines but since this is my first go please be gentle! n.b. Seems there is probably an existing issue that means clearing the menu only shows cleared if you click on another window and back on CodeEdit. My change did not introduce this issue, I tested with the downloaded pre built 'PRE' version to be sure.

Related Issues

• ✨ Separate files and folders in the "Open Recent" sub-menu #1061

Checklist

• I read and understood the contributing guide as well as the code of conduct
• The issues this PR addresses are related to each other
• My changes generate no new warnings
• My code builds and runs on my machine
• My changes are all related to the related issue above
• I documented my code

Screenshots

[austincondiff]

Nice work! We probably want to keep individual files in the welcome windows recents list. They should be interspersed together with the folders sorted by date.

[atsrus]

Ok I can take a look at that as well (assuming it's not above my pay grade). I had made a poor assumption that it was also limited length list ,but I see it scrolls . Should I look at this as part of this same issue, and just carry on where I left off ? (Off on holiday tomorrow, I'll try and take look while away (if Im allowed !).

[austincondiff]

Not sure I completely understand the limit/scroll issue, but each of the following lists should be limited to 10 items:

• Recent Folders Menu
• Recent Files Menu
• Welcome Window Recent Files and Folders

[thecoolwinter]

I like this change! Thanks for getting started on it.

We haven't limited the welcome window's length to ten in the past, you can leave that out in this PR since we're limiting it to 100 items in the data model anyways (and scope creep).

One suggestion, it might be easier to keep the single array of past items, and in the menu item just filter for a list of directories and a list of single files. That'd leave the welcome window intact with no changes, and wouldn't require some of the duplicated logic in the model (eg where you had to duplicate the de-duplication code).

Since we're always limiting history to 100 items, I doubt a simple filter like that would be problematic performance-wise.

[thecoolwinter]

@atsrus I'm going to quick get this ready to merge since this is a feature we very much want but there hasn't been any activity on this PR for a second. I appreciate the work done, the changes I'd like are small and build on what you did already.

[thecoolwinter]

Should be good to go now!

[atsrus]

Hi sorry guys. Back from Holiday now. Sorry I wasn't around when you progressed. I want to see my very first change through, so that will teach me to go on holiday.!

[austincondiff]

@atsrus no worries! Thanks again for your hard work in getting this changed.