Skip to content

Added check for git installation presence #2047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2025

Conversation

rustemd02
Copy link
Contributor

Description

Added Git installation checking before attempting to clone a repository. Instead of silently opening an empty workspace when Git is not available, users now receive an alert message informing them that Git is required.

The implementation adds:

  1. A new isGitInstalled() method that validates Git installation by running the "which git" command and checking its exit status
  2. A validation check at the beginning of the cloneRepository() method that displays a user-friendly error when Git is not detected

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Снимок экрана 2025-05-17 в 11 17 21

Copy link
Collaborator

@thecoolwinter thecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@thecoolwinter
Copy link
Collaborator

Not sure why that test is failing, I'll take a look it might be an issue with the CI runner.

@thecoolwinter
Copy link
Collaborator

We've merged a fix for the CI issue. If you'd be willing to merge from the main branch, tests should pass.

thecoolwinter
thecoolwinter previously approved these changes May 29, 2025
Copy link
Collaborator

@thecoolwinter thecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! 👍

0xWDG
0xWDG previously approved these changes May 29, 2025
@austincondiff austincondiff dismissed stale reviews from 0xWDG and thecoolwinter via 53fccd8 May 29, 2025 16:26
@austincondiff austincondiff merged commit 76d4d01 into CodeEditApp:main May 29, 2025
@austincondiff
Copy link
Collaborator

@allcontributors add @rustemd02 for bug and code

Copy link
Contributor

@austincondiff

I've put up a pull request to add @rustemd02! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants