Skip to content

WelcomeWindow Package Implementation #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 17, 2025

Conversation

georgetchelidze
Copy link
Contributor

@georgetchelidze georgetchelidze commented Jun 8, 2025

Description

  • Removed old welcome window code and implemented WelcomeWindow package.
  • Refactored related code in RecentProjectsMenu and CodeEditDocumentController.
  • Recreated views that go inside the welcome window in Features/Welcome

Related Issues

None.

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

WelcomeWindow UI updates from PR#2040
Screenshot 2025-06-08 at 20 15 27

@georgetchelidze georgetchelidze changed the title Implemented WelcomeWindow Package WelcomeWindow Package Implementation Jun 8, 2025
thecoolwinter
thecoolwinter previously approved these changes Jun 16, 2025
Copy link
Collaborator

@thecoolwinter thecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work again, I made one last small change on the WelcomeWindow fixing an issue related to opening files/folders from the button.

Again, thank you for doing this work!

austincondiff
austincondiff previously approved these changes Jun 16, 2025
@austincondiff
Copy link
Collaborator

austincondiff commented Jun 16, 2025

@thecoolwinter Should we wait for a formal release of the WelcomeWindow package before merging this?

@thecoolwinter
Copy link
Collaborator

@thecoolwinter Should we wait for a formal release of the WelcomeWindow package before merging this?

I made a v1.0.0 release tag there, this does reference the main branch. I could quick change that if you think it's necessary.

@austincondiff
Copy link
Collaborator

Yeah, if you wouldn't mind. Feel free to merge after

@thecoolwinter thecoolwinter dismissed stale reviews from austincondiff and themself via 7de0df8 June 17, 2025 15:10
@thecoolwinter thecoolwinter merged commit d6c2e0f into CodeEditApp:main Jun 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants