Skip to content

AboutWindow Package Implementation #2060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 17, 2025

Conversation

georgetchelidze
Copy link
Contributor

Description

  • Removed old about window code and implemented AboutWindow Package
  • Modified ContributorsView and AcknowledgementsView's to follow the new package patterns.
  • Created AboutFooterView and AboutSubtitleView's.
  • Implemented changes proposed by Khan in PR Copy Version Information On Click #2056

Related Issues

None.

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

None.

Copy link
Collaborator

@thecoolwinter thecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you thank you for the work to bring this into a standalone package.

Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks again for the excellent work on this! 🚀

@georgetchelidze
Copy link
Contributor Author

Thanks both! Glad you like it, always happy to help!

@austincondiff
Copy link
Collaborator

@thecoolwinter should we wait to merge until we have a formal release for the AboutWindow package?

@thecoolwinter
Copy link
Collaborator

@austincondiff we've got a release cut, v1.0.0.

@thecoolwinter thecoolwinter merged commit 149f97b into CodeEditApp:main Jun 17, 2025
2 checks passed
@thecoolwinter
Copy link
Collaborator

@allcontributors please add @georgetchelidze for code

Copy link
Contributor

@thecoolwinter

I've put up a pull request to add @georgetchelidze! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants