Skip to content

feat: source_uuid to multiscan #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alina-tuholukova-gg
Copy link
Contributor

When source_uuid parameter is provided for the multiscan endpoint, the incidents will be
created for the found secrets

@alina-tuholukova-gg alina-tuholukova-gg requested a review from a team as a code owner June 4, 2025 12:37
@alina-tuholukova-gg alina-tuholukova-gg self-assigned this Jun 4, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2025

Codecov Report

Attention: Patch coverage is 88.57143% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.57%. Comparing base (be13fe7) to head (0f89473).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
pygitguardian/client.py 82.35% 3 Missing ⚠️
pygitguardian/models.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
- Coverage   95.77%   95.57%   -0.21%     
==========================================
  Files           5        5              
  Lines        1208     1243      +35     
==========================================
+ Hits         1157     1188      +31     
- Misses         51       55       +4     
Flag Coverage Δ
unittests 95.57% <88.57%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alina-tuholukova-gg alina-tuholukova-gg force-pushed the alina/add-source-id-parameter-for-multiscan branch from 89889f1 to 90b4d91 Compare June 4, 2025 12:54
@alina-tuholukova-gg alina-tuholukova-gg force-pushed the alina/add-source-id-parameter-for-multiscan branch 2 times, most recently from 02eb61e to ea1cd34 Compare June 4, 2025 12:58
Copy link
Collaborator

@agateau-gg agateau-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I am curious about how one does obtain this source_uuid.

@alina-tuholukova-gg alina-tuholukova-gg force-pushed the alina/add-source-id-parameter-for-multiscan branch from ea1cd34 to 839ff83 Compare June 23, 2025 16:08
@alina-tuholukova-gg alina-tuholukova-gg force-pushed the alina/add-source-id-parameter-for-multiscan branch from 839ff83 to 0f89473 Compare June 23, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants