-
-
Notifications
You must be signed in to change notification settings - Fork 7k
[python] Fix poetry deprecation warnings #21268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Fix poetry deprecation warnings #21268
Conversation
thanks for the pr is the change backward compatible with poetry 1.x? |
Hi @wing328, It is not backwards compatible with Poetry 1.x. That is also why I added this line: https://github.com/4c0n/openapi-generator/blob/b554c1bc3adc621f144c46112b6a00a526e59246/modules/openapi-generator/src/main/resources/python/pyproject.mustache#L32 If people are still using 1.x I'd say it's about time to upgrade or use an older version of the generator as well😄. |
for the upcoming release v7.14.0, we only allow breaking changes with fallbacks only. can we add an option (default to false) to let users fallback to poetry 1.x? |
@wing328 I added a fallback option, hope this is sufficient? |
if no one has feedback/question on this pr, i'll merge it later this week |
fyi. merged #21328 to update samples with a test |
Thank you @wing328 :) |
Since the release of Poetry 2.0.0 the format of
pyproject.toml
that it is expecting changed.See also: https://python-poetry.org/blog/announcing-poetry-2.0.0
This PR aims to update the pyproject.toml file to a format that does not use (now) deprecated features introduced by Poetry 1.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)