Skip to content

[cpp-restsdk] link cpprest without crypto libraries #21348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025

Conversation

aminya
Copy link
Contributor

@aminya aminya commented May 29, 2025

These libraries aren't needed in the generated code. We don't need to link bcrypt directly. Cpprest itself handles its bcrypt dependencies.
https://github.com/microsoft/cpprestsdk/blob/0b1ce318a757bbfb89bdb0fffb61ca4e38dc3b33/Release/src/CMakeLists.txt#L212
It uses OpenSSL for other crypto usage.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

These libraries aren't needed in the generated code. Cpprest doesn't need the crypto libraries directly. It uses OpenSSL
@aminya aminya closed this May 29, 2025
@aminya aminya deleted the cpp-crypto branch May 29, 2025 09:26
@aminya aminya restored the cpp-crypto branch May 29, 2025 09:27
@aminya aminya reopened this May 29, 2025
@wing328
Copy link
Member

wing328 commented Jun 1, 2025

cc @ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03) @muttleyxd (2019/08) @aminya (2025/05)

@wing328 wing328 added this to the 7.14.0 milestone Jun 1, 2025
@wing328
Copy link
Member

wing328 commented Jun 2, 2025

tested locally and the result is good

cinationBook.cpp.o
[ 88%] Building CXX object CMakeFiles/CppRestPetstoreClient.dir/src/model/Tag.cpp.o
[ 92%] Building CXX object CMakeFiles/CppRestPetstoreClient.dir/src/model/User.cpp.o
[ 96%] Building CXX object CMakeFiles/CppRestPetstoreClient.dir/src/model/Vaccine.cpp.o
[100%] Linking CXX static library libCppRestPetstoreClient.a
[100%] Built target CppRestPetstoreClient
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:47 min
[INFO] Finished at: 2025-06-02T16:54:21+08:00
[INFO] ------------------------------------------------------------------------

@wing328 wing328 merged commit 18ccf86 into OpenAPITools:master Jun 2, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants