Skip to content

Commit 7c96f9f

Browse files
committed
[smarcet] - #14664
* redirectig report a problem to github tracker * refactoring
1 parent 29442e0 commit 7c96f9f

File tree

3 files changed

+46
-21
lines changed

3 files changed

+46
-21
lines changed

app/src/main/java/org/openstack/android/summit/modules/about/user_interface/AboutFragment.java

Lines changed: 4 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
package org.openstack.android.summit.modules.about.user_interface;
22

33
import android.content.Context;
4-
import android.content.Intent;
54
import android.content.pm.PackageInfo;
65
import android.content.pm.PackageManager;
7-
import android.net.Uri;
86
import android.os.Bundle;
97
import android.view.LayoutInflater;
108
import android.view.View;
@@ -108,33 +106,19 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle sa
108106
setBuild(String.format(Locale.US, "Build Number %s", pInfo.versionCode));
109107

110108
websiteLink.setOnClickListener(v -> {
111-
Uri uri = Uri.parse("https://www.openstack.org/summit");
112-
Intent intent = new Intent(Intent.ACTION_VIEW, uri);
113-
startActivity(intent);
109+
presenter.redirect2SummitPage();
114110
});
115111

116112
conductLink.setOnClickListener(v -> {
117-
Uri uri = Uri.parse("https://www.openstack.org/code-of-conduct/");
118-
Intent intent = new Intent(Intent.ACTION_VIEW, uri);
119-
startActivity(intent);
113+
presenter.redirect2CodeConductPage();
120114
});
121115

122116
supportLink.setOnClickListener(v -> {
123-
Intent emailIntent = new Intent(Intent.ACTION_SEND);
124-
emailIntent.setType("plain/text");
125-
emailIntent.putExtra(Intent.EXTRA_EMAIL,new String[] {"summitapp@openstack.org" });
126-
emailIntent.putExtra(Intent.EXTRA_SUBJECT, "");
127-
emailIntent.putExtra(Intent.EXTRA_TEXT,"");
128-
startActivity(Intent.createChooser(emailIntent, "Send mail..."));
117+
presenter.redirect2IssueTrackerPage();
129118
});
130119

131120
inquiriesLink.setOnClickListener(v -> {
132-
Intent emailintent = new Intent(Intent.ACTION_SEND);
133-
emailintent.setType("plain/text");
134-
emailintent.putExtra(Intent.EXTRA_EMAIL,new String[] {"summit@openstack.org" });
135-
emailintent.putExtra(Intent.EXTRA_SUBJECT, "");
136-
emailintent.putExtra(Intent.EXTRA_TEXT,"");
137-
startActivity(Intent.createChooser(emailintent, "Send mail..."));
121+
presenter.sendInquireEmail();
138122
});
139123

140124
presenter.onCreateView(savedInstanceState);

app/src/main/java/org/openstack/android/summit/modules/about/user_interface/AboutPresenter.java

Lines changed: 34 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package org.openstack.android.summit.modules.about.user_interface;
22

3+
import android.content.Intent;
4+
import android.net.Uri;
35
import android.os.Bundle;
46

57
import org.openstack.android.summit.common.DTOs.SummitDTO;
@@ -15,7 +17,7 @@
1517
/**
1618
* Created by Claudio Redi on 4/1/2016.
1719
*/
18-
public class AboutPresenter extends BasePresenter<IAboutView, IAboutInteractor, IAboutWireframe> implements IAboutPresenter {
20+
public final class AboutPresenter extends BasePresenter<IAboutView, IAboutInteractor, IAboutWireframe> implements IAboutPresenter {
1921

2022
private List<WifiListItemDTO> wifiList = new ArrayList<>();
2123

@@ -43,4 +45,35 @@ public void buildWifiListItem(WifiItemView wifiItemView, int position) {
4345
wifiItemView.setSsid(wifiListItemDTO.getSsid());
4446
wifiItemView.setPassword(wifiListItemDTO.getPassword());
4547
}
48+
49+
@Override
50+
public void redirect2IssueTrackerPage() {
51+
Uri uri = Uri.parse("https://github.com/OpenStack-mobile/summit-app-android/issues");
52+
Intent intent = new Intent(Intent.ACTION_VIEW, uri);
53+
view.startActivity(intent);
54+
}
55+
56+
@Override
57+
public void redirect2SummitPage() {
58+
Uri uri = Uri.parse("https://www.openstack.org/summit");
59+
Intent intent = new Intent(Intent.ACTION_VIEW, uri);
60+
view.startActivity(intent);
61+
}
62+
63+
@Override
64+
public void redirect2CodeConductPage() {
65+
Uri uri = Uri.parse("https://www.openstack.org/code-of-conduct/");
66+
Intent intent = new Intent(Intent.ACTION_VIEW, uri);
67+
view.startActivity(intent);
68+
}
69+
70+
@Override
71+
public void sendInquireEmail() {
72+
Intent emailintent = new Intent(Intent.ACTION_SEND);
73+
emailintent.setType("plain/text");
74+
emailintent.putExtra(Intent.EXTRA_EMAIL,new String[] {"summit@openstack.org" });
75+
emailintent.putExtra(Intent.EXTRA_SUBJECT, "");
76+
emailintent.putExtra(Intent.EXTRA_TEXT,"");
77+
view.startActivity(Intent.createChooser(emailintent, "Send mail..."));
78+
}
4679
}

app/src/main/java/org/openstack/android/summit/modules/about/user_interface/IAboutPresenter.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,12 @@
99
public interface IAboutPresenter extends IBasePresenter<IAboutView> {
1010

1111
void buildWifiListItem(WifiItemView wifiItemView, int position);
12+
13+
void redirect2IssueTrackerPage();
14+
15+
void redirect2SummitPage();
16+
17+
void redirect2CodeConductPage();
18+
19+
void sendInquireEmail();
1220
}

0 commit comments

Comments
 (0)