Increase test coverage for MarkdownFormatter

Author: afilina

phpunit.xml.dist

@@ -1,13 +1,22 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd" bootstrap="./tests/bootstrap.php" backupGlobals="true" colors="true" forceCoversAnnotation="true">
-  <coverage>
-    <include>
-      <directory>./src</directory>
-    </include>
-  </coverage>
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.0/phpunit.xsd"
+         bootstrap="vendor/autoload.php"
+         executionOrder="depends,defects"
+         forceCoversAnnotation="true"
+         beStrictAboutOutputDuringTests="true"
+         beStrictAboutTodoAnnotatedTests="true"
+         verbose="true">
+
   <testsuites>
     <testsuite name="Unit Tests">
       <directory>tests</directory>
     </testsuite>
   </testsuites>
+
+  <filter>
+    <whitelist processUncoveredFilesFromWhitelist="true">
+      <directory suffix=".php">src</directory>
+    </whitelist>
+  </filter>
 </phpunit>

tests/App/Generator/Formatter/MarkdownFormatterTest.php

@@ -17,6 +17,19 @@ final class MarkdownFormatterTest extends TestCase
 {
     private MarkdownFormatter $formatter;
 
+    private function createSniff(): Sniff
+    {
+        return new Sniff(
+            'Standard.Category.My',
+            '',
+            [],
+            new UrlList([]),
+            '',
+            [],
+            []
+        );
+    }
+
     /** @test */
     public function formatDescription(): void
     {
@@ -30,16 +43,14 @@ public function formatDescription(): void
         );
     }
 
-    private function createSniff(): Sniff
+    /** @test */
+    public function formatDescription_WithBlankString_ReturnBlankString(): void
     {
-        return new Sniff(
-            'Standard.Category.My',
-            '',
-            [],
-            new UrlList([]),
+        self::assertEquals(
             '',
-            [],
-            []
+            $this->formatter->formatDescription(
+                $this->createSniff()->withDescription('')
+            )
         );
     }
 
@@ -58,6 +69,17 @@ public function formatDocblock(): void
         );
     }
 
+    /** @test */
+    public function formatDocblock_WithBlankString_ReturnBlankString(): void
+    {
+        self::assertEquals(
+            '',
+            $this->formatter->formatDocblock(
+                $this->createSniff()->withDocblock('')
+            )
+        );
+    }
+
     /** @test */
     public function formatComparisons(): void
     {
@@ -84,6 +106,17 @@ public function formatComparisons(): void
         );
     }
 
+    /** @test */
+    public function formatComparisons_WithEmptyList_ReturnBlankString(): void
+    {
+        self::assertEquals(
+            '',
+            $this->formatter->formatComparisons(
+                $this->createSniff()->withDiffs([])->getDiffs()
+            )
+        );
+    }
+
     /** @test */
     public function formatPublicProperties(): void
     {
@@ -103,6 +136,17 @@ public function formatPublicProperties(): void
         );
     }
 
+    /** @test */
+    public function formatPublicProperties_WithEmptyList_ReturnBlankString(): void
+    {
+        self::assertEquals(
+            '',
+            $this->formatter->formatPublicProperties(
+                $this->createSniff()->withProperties([])->getProperties()
+            )
+        );
+    }
+
     /** @test */
     public function formatSeeAlso(): void
     {
@@ -122,6 +166,17 @@ public function formatSeeAlso(): void
         );
     }
 
+    /** @test */
+    public function formatSeeAlso_WithEmptyList_ReturnBlankString(): void
+    {
+        self::assertEquals(
+            '',
+            $this->formatter->formatSeeAlso(
+                $this->createSniff()->withUrls(new UrlList([]))->getUrls()
+            )
+        );
+    }
+
     /** @test */
     public function formatViolations(): void
     {
@@ -164,6 +219,17 @@ public function formatViolations(): void
         );
     }
 
+    /** @test */
+    public function formatViolations_WithEmptyList_ReturnBlankString(): void
+    {
+        self::assertEquals(
+            '',
+            $this->formatter->formatViolations(
+                $this->createSniff()->withViolations([])->getViolations()
+            )
+        );
+    }
+
     protected function setUp(): void
     {
         $this->formatter = new MarkdownFormatter();

tests/Generator/JekyllPageGeneratorTest.php

@@ -12,7 +12,7 @@
 use App\Value\Violation;
 use PHPUnit\Framework\TestCase;
 
-/** @covers \App\Generator\JekyllPage */
+/** @covers \App\Generator\JekyllPageGenerator */
 class JekyllPageGeneratorTest extends TestCase
 {
     private JekyllPageGenerator $generator;