Refactor to use configurable repos and standards; clean up code

Author: afilina

.gitignore

@@ -1,4 +1,5 @@
 vendor
 var
+!var/tests/repo
 !var/**/.gitkeep
 .phpunit.result.cache

composer.lock

@@ -2,14 +2,20 @@
 declare(strict_types=1);
 
 use App\CodeRepository\CodeRepository;
-use App\CodeRepository\GithubCodeRepository;
+use App\CodeRepository\GitCodeRepository;
+use App\Configuration\ConfigurationRepository;
+use App\Configuration\XmlConfigurationRepository;
 use App\Generator\Generator as DocGenerator;
 use App\Generator\MarkdownGenerator;
 use App\SniffFinder\FilesystemSniffFinder;
 use App\SniffFinder\SniffFinder;
+use App\Value\Folder;
 
 return [
-    CodeRepository::class => DI\autowire(GithubCodeRepository::class),
+    CodeRepository::class => DI\autowire(GitCodeRepository::class),
     DocGenerator::class => DI\autowire(MarkdownGenerator::class),
     SniffFinder::class => DI\autowire(FilesystemSniffFinder::class),
+    ConfigurationRepository::class => DI\factory(function () {
+        return new XmlConfigurationRepository(new Folder(__DIR__ . '/../'));
+    })
 ];

config/di.php

@@ -1,10 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <generator format="markdown">
-    <sources>
-        <source path="git@github.com:PHPCompatibility/PHPCompatibility.git">
-            <standards>
-                <standard path="PHPCompatibility" />
-            </standards>
-        </source>
-    </sources>
+    <source path="git@github.com:PHPCompatibility/PHPCompatibility.git">
+        <standard path="PHPCompatibility" />
+    </source>
 </generator>

generator.xml.dist

@@ -3,11 +3,12 @@
 
 namespace App\CodeRepository;
 
+use App\Configuration\Value\Source;
 use App\Value\Folder;
 
 interface CodeRepository
 {
     public const CODE_DOWNLOAD_PATH = 'var/repos/';
 
-    public function downloadCode(string $repoName): Folder;
+    public function getFolder(Source $source): Folder;
 }

src/CodeRepository/CodeRepository.php

@@ -8,16 +8,14 @@
 use Symfony\Component\Process\Exception\ProcessFailedException;
 use Symfony\Component\Process\Process;
 
-class GithubCodeRepository implements CodeRepository
+class GitCodeRepository implements CodeRepository
 {
-    public function downloadCode(Source $source): Folder
+    public function getFolder(Source $source): Folder
     {
-        $localPath = new Folder(self::CODE_DOWNLOAD_PATH . $source->getLocalFolder() . '/');
+        $this->runProcess($this->getCloneOrPullProcess($source->getLocalFolder(), $source->getPath()));
+        $this->runProcess($this->getComposerInstallProcess($source->getLocalFolder()));
 
-        $this->runProcess($this->getCloneOrPullProcess($localPath, $source->getPath()));
-        $this->runProcess($this->getComposerInstallProcess($localPath));
-
-        return $localPath;
+        return $source->getLocalFolder();
     }
 
     private function runProcess(Process $process): void

src/CodeRepository/GitCodeRepository.php

@@ -3,13 +3,22 @@
 
 namespace App\Configuration\Value;
 
+use App\CodeRepository\CodeRepository;
+use App\Value\Folder;
+use function Stringy\create as s;
+
 final class Source
 {
+    public const TYPE_GIT = 'git';
+    public const TYPE_LOCAL = 'local';
+
     private string $path;
     /**
      * @var Standard[]
      */
     private array $standards;
+    private Folder $localFolder;
+    private string $type = self::TYPE_LOCAL;
 
     /**
      * @param Standard[] $standards
@@ -18,13 +27,32 @@ public function __construct(string $path, array $standards)
     {
         $this->path = $path;
         $this->standards = $standards;
+
+        if (preg_match('/([^.\/]+)\.git$/', $path, $matches)) {
+            $this->localFolder = $this->createLocalFolder(CodeRepository::CODE_DOWNLOAD_PATH . $matches[1]);
+            $this->type = self::TYPE_GIT;
+            return;
+        }
+
+        $this->localFolder = $this->createLocalFolder($path);
+    }
+
+    private function createLocalFolder(string $path): Folder
+    {
+        $path = s($path)->ensureRight('/');
+        return new Folder((string)$path);
     }
 
     public function getPath(): string
     {
         return $this->path;
     }
 
+    public function getLocalFolder(): Folder
+    {
+        return $this->localFolder;
+    }
+
     /**
      * @return Standard[]
      */

src/Configuration/Value/Source.php

@@ -22,7 +22,7 @@ public function __construct(Folder $root)
 
     public function getConfig(): Configuration
     {
-        $paths = [$this->root . 'generator.xml', $this->root . '/generator.xml.dist'];
+        $paths = [$this->root . 'generator.xml', $this->root . 'generator.xml.dist'];
         foreach ($paths as $path) {
             if (file_exists($path)) {
                 return $this->parse($path);
@@ -39,7 +39,7 @@ private function parse(string $path): Configuration
         $dom = new DOMDocument;
         $dom->load($path);
 
-        set_error_handler(function(int $number, string $error) use ($path) {
+        set_error_handler(function (int $number, string $error) use ($path) {
             throw new RuntimeException(
                 sprintf("The configuration file %s is invalid.\n%s", $path, $error)
             );