chore:Remove symlink in react query #9346
Open
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit c886b9e
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9346 +/- ##
===========================================
+ Coverage 45.39% 84.38% +38.99%
===========================================
Files 208 26 -182
Lines 8279 365 -7914
Branches 1872 107 -1765
===========================================
- Hits 3758 308 -3450
+ Misses 4080 48 -4032
+ Partials 441 9 -432 🚀 New features to boost your workflow:
|
TkDodo
requested changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #9272, there were issues with configuration imports through symlinks.
While thinking about this problem, I came across the implementation of the react-router library. I found that this library solves the issue by simply importing with relative paths.
example
When I applied this approach to react-query and tested it on Windows, I confirmed that both ESLint and tsup work well.
If this PR gets merged, we should be able to remove other symlinks using the same approach as this PR. And it will enable development of tanstack query on Windows as well!