Multiline strings are not indented properly

[blueyed]

I consider the following to be good:

        testdir.makeini("""
            [pytest]
            paths=blah.py""")

But currently it becomes:

        testdir.makeini("""
[pytest]
                        paths=blah.py""")

[blueyed]

I've started working on fixing it.

[hynek]

I don't think then lines after """ should be indented. It forces the user to run dedent on it.

[blueyed]

I don't think then lines after """ should be indented. It forces the user to run dedent on it.

It would keep manually indented lines: so you would dedent manually after <cr> and then lines after it would also be indented in the same way, e.g.:

There could also be an option for this behavior.

We agree though that the current behavior is just wrong, right? :)

[blueyed]

What behavior would you line to control?

Should be the indent after test("""foo controllable in a different way from test("""?
Would you like to have it being 0 for you in both cases?

[blueyed]

Added a setting for this - previous question still remains. Currently the setting gets used regardless of if there is something after the opening """.

[hynek]

yes i think there should be no difference. """ are literal strings so I feel they should be as literal as possible by default. :)

[blueyed]

@hynek
I think existing indent should be kept though, do you agree?
So you would get 0 as proposed indent, but already indented lines would not get changed.
(That is not really relevant to the existing PR, but a fix before this)

[hynek]

you mean like:

foo = """
X
   abc
   Y
"""

• enter after """, you end up at X
• enter after c, you wind up at Y

?

[blueyed]

@hynek
Yes, that behavior will be kept.

But I've meant that when using == etc on a non-empty line that is in a multiline string, the existing indentation won't be changed.

[blueyed]

I've worked some more on #50 and think it should be good by now, please review it.