Skip to content

readme on configuration very unclear #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jimbasquiat opened this issue May 20, 2017 · 21 comments
Closed

readme on configuration very unclear #75

jimbasquiat opened this issue May 20, 2017 · 21 comments
Labels

Comments

@jimbasquiat
Copy link

Hi,

I have been trying to make use of this plugin - however the readme supposed to explain the configuration is very unclear. Could you expand a little bot on how to use this plugin - maybe fr instance showing 1 or 2 examples of the most common config you would recommand?

@blueyed
Copy link
Member

blueyed commented May 20, 2017

@jimbasquiat
I am using just the default settings myself.

A PR with improved doc would be nice, if you can figure something out etc.

@jimbasquiat
Copy link
Author

jimbasquiat commented May 20, 2017 via email

@blueyed
Copy link
Member

blueyed commented May 20, 2017

What does :verb set indentexpr? give you?
It should be indentexpr=GetPythonPEPIndent(v:lnum).
Make sure the filetype is python.

@jimbasquiat
Copy link
Author

jimbasquiat commented May 20, 2017 via email

@blueyed
Copy link
Member

blueyed commented May 20, 2017

It should do so, via ftplugin indent - so it depends on how you load it.
I recommend using a plugin manager like vim-plug.

@jimbasquiat
Copy link
Author

jimbasquiat commented May 20, 2017 via email

@blueyed
Copy link
Member

blueyed commented May 20, 2017

Sorry, I've meant filetype indent on, see :h :filetype-indent-on.

pathogen is quite basic, so make sure to follow its documentation regarding those :filetype calls.

https://github.com/Vimjas/vim-python-pep8-indent/blob/master/indent/python.vim is the file that should get loaded for ft=python.

@blueyed
Copy link
Member

blueyed commented May 20, 2017

@jimbasquiat
Copy link
Author

This is completely confusing.... Why do i need to read and digest all the details of pathogen to have your plugin to work?
Concretely, what action do i need to perform once i did "git clone https://github.com/Vimjas/vim-python-pep8-indent.git", in the .vim/bundle directory, using pathogen ?
Thank you

@blueyed
Copy link
Member

blueyed commented May 20, 2017

It's more about having your pathogen setup correctly after all.

It's not just about this plugin, but plugins in general.

Using a more sophisticated plugin manager like vim-plug helps you with that, but if you want to use pathogen, you have to use it correctly.. :)

@jimbasquiat
Copy link
Author

my pathogen setup has worked well with all plugins except yours.
While asking for a simple help on a setup with yours you werent able to explain it in simpler terms (albeit you managed to come back with even more confused explanations) and then give me this passive agressive crap.
No need to pretend to be maintaining this package or even to reply to the issue thread if its to throw stuff like that at people.

@blueyed
Copy link
Member

blueyed commented May 20, 2017

What is passive-aggressive from my side?
I'm trying to help you while I am pretty certain that your pathogen setup is not working correctly (and told you at least twice).
You have not shown your vimrc for example, nor a minimal vimrc which shows that it fails there.
There are dozens or hundreds of users (according to the GH stars) where setup is not an issue.

@blueyed
Copy link
Member

blueyed commented May 20, 2017

my pathogen setup has worked well with all plugins except yours.

Do you use other indent plugins?

@blueyed
Copy link
Member

blueyed commented May 20, 2017

And it is pretty clear that your initial issue was about configuration of the plugin, while it only turned out later that it is not loading/working for your in general.

@jimbasquiat
Copy link
Author

no i am not using any other indent plugin

@blueyed
Copy link
Member

blueyed commented May 20, 2017

You can try using a minimal.vimrc (from this plugin's directory) via vim -Nu minimal.vimrc:

let &runtimepath=$PWD.','.&rtp
filetype plugin indent on

This should load the plugin.

As for using pathogen, it should work when properly configured, i.e. following https://github.com/tpope/vim-pathogen#runtime-path-manipulation.

@jimbasquiat
Copy link
Author

So the .vimrc had to be modified? How are users supposed to guess that? Beside I tried your suggestion but it doesn't work. But I give up. I don't doubt your good faith in trying to provide a solution or your coder's skills, but you just seem unable to express yourself in a way that's clear.

@redNixon
Copy link

"filetype plugin indent on" is disabled by default on Ubuntu(possibly others to make it more vi like), that is probably what the issue is. Even with autoindent and smartindent enabled this plugin does not activate, it is not an obvious fix unless you know the internals of vim.

Quick blindfix for you is probably:
echo "filetype plugin indent on" >> ~/.vimrc

If you added anything else in vimrc while debugging this I would take it out(not sure what setting the runtimepath could affect).

@blueyed
Copy link
Member

blueyed commented Jun 18, 2017

@redNixon
Thanks!

@jimbasquiat
In case you want to give it another try, please let us know if that fixes it for you.

I think we should update the README to include this note then anyway.
Strictly speaking only the filetype indent on would be required, right?

@redNixon
Copy link

Correct, I tested using Ubuntu 16.04 and a vimrc file with only filetype enabled and seemed to worked fine.

@blueyed
Copy link
Member

blueyed commented Jul 15, 2018

Added a Troubleshooting section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants