Skip to content

Fix indentation of "else" in nested "if" #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2016
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 20 additions & 13 deletions indent/python.vim
Original file line number Diff line number Diff line change
@@ -145,20 +145,26 @@ endfunction
" Find possible indent(s) of the block starter that matches the current line.
function! s:find_start_of_block(lnum, types, multiple)
let r = []
let types = copy(a:types)
let re = '\V\^\s\*\('.join(a:types, '\|').'\)\>'
let lnum = a:lnum
let last_indent = indent(lnum) + 1
while lnum > 0 && last_indent > 0
let indent = indent(lnum)
if indent < last_indent
if getline(lnum) =~# re
if !a:multiple
return [indent]
for type in types
let re = '\v^\s*'.type.'>'
if getline(lnum) =~# re
if !a:multiple
return [indent]
endif
if index(r, indent) == -1
let r += [indent]
endif
" Remove any handled type, e.g. 'if'.
call remove(types, index(types, type))
endif
if !len(r) || index(r, indent) == -1
let r += [indent]
endif
endif
endfor
let last_indent = indent(lnum)
endif
let lnum = prevnonblank(lnum - 1)
@@ -239,14 +245,15 @@ function! s:indent_like_block(lnum)
if len(indents) == 1
return indents[0]
endif

" Multiple valid indents, e.g. for 'else' with both try and if.
let indent = indent(a:lnum)
for possible_indent in indents
if indent == possible_indent
return indent
endif
endfor
return -2
if index(indents, indent) != -1
" The indent is valid, keep it.
return indent
endif
" Fallback to the first/nearest one.
return indents[0]
endfor
endfor
return -2
8 changes: 8 additions & 0 deletions spec/indent/indent_spec.rb
Original file line number Diff line number Diff line change
@@ -361,6 +361,14 @@
end
end

describe "when an else is used inside of a nested if" do
before { vim.feedkeys 'iif foo:\<CR>\<TAB>if bar:\<CR>\<TAB>\<TAB>pass\<CR>' }
it "indents an else to the inner if" do
vim.feedkeys 'else:'
indent.should == shiftwidth * 2
end
end

describe "when jedi-vim call signatures are used" do
before { vim.command 'syn match jediFunction "JEDI_CALL_SIGNATURE" keepend extend' }