feat!: support previous non-E2E #1817
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| } else { | ||
| Window window = cordova.getActivity().getWindow(); | ||
| int uiOptions = window.getDecorView().getSystemUiVisibility(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| uiOptions |= flags; | ||
| window.addFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN); | ||
| } | ||
| window.getDecorView().setSystemUiVisibility(uiOptions); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
|
|
||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) { | ||
| // Allow custom navigation bar background color for SDK 26 and greater. | ||
| window.setNavigationBarColor(bgColor); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| window.setNavigationBarColor(bgColor); | ||
| } else { | ||
| // Force navigation bar to black for SDK 25 and less. | ||
| window.setNavigationBarColor(Color.BLACK); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| controllerCompat.setAppearanceLightStatusBars(isStatusBarBackgroundColorLight); | ||
|
|
||
| // Allow custom background color for StatusBar. | ||
| window.setStatusBarColor(bgColor); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| private View getStatusBarView(CordovaWebView webView) { | ||
| FrameLayout rootView = getRootLayout(webView); | ||
| for (int i = 0; i < (rootView != null ? rootView.getChildCount() : 0); i++) { | ||
| View child = rootView.getChildAt(i); |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null Warning
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1817 +/- ##
==========================================
+ Coverage 72.12% 72.63% +0.51%
==========================================
Files 23 23
Lines 1844 1831 -13
==========================================
Hits 1330 1330
+ Misses 514 501 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } | ||
| } | ||
|
|
||
| private void setStatusBarBackgroundColor(final String colorPref) { |
There was a problem hiding this comment.
For iOS, I passed the colour values as 3 integers, which allowed a bit more flexibility in how it was specified on the JS side (i.e., to allow setting it to rgb(123 234 124) or maroon and using CSS.getComputedStyle to parse it and guarantee we'd get 3 RGB components)
| // Confirm if value is a valid hex code is before passing to native-side | ||
| if (!(/^#(?:[0-9a-fA-F]{6}|[0-9a-fA-F]{8})$/.test(value))) { | ||
| console.error('Invalid color hex code. Valid format: #RRGGBB or #AARRGGBB'); | ||
| return; | ||
| } |
There was a problem hiding this comment.
The iOS side did some smart parsing using the getComputedStyle API to take any valid CSS colour specification and get back RGB components
|
You might be able to use |
erisu
force-pushed
the
feat/non-e2e-and-improved-system-bar-theming
branch
from
b4e4b54 to
250a0c6
Compare
erisu
changed the title
Motivation and Context
Description
StatusBar JS API:
window.statusbar.visible = <true|false>window.statusbar.setBackgroundColor('#AARRGGBB')`config.xml preferences:
This PR reuses all of the previous preferences. Order of imports listed below
StatusBarBackgroundColorBackgroundColorBackgroundColorTesting
npm tChecklist
(platform)if this change only applies to one platform (e.g.(android))