Skip to content

Mickey🍉 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2025
Merged

Mickey🍉 #11

merged 2 commits into from
Jul 27, 2025

Conversation

MickeyShahzad
Copy link
Contributor

Made small edits to increase efficiency, added a few more test cases.

@aviiciii aviiciii requested a review from Copilot July 27, 2025 08:41
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds additional test cases to improve test coverage across multiple test files and refactors code in the extensions module to use a more efficient dictionary-based approach instead of multiple if-else statements. It also fixes a syntax error in the outdated module.

  • Added test cases for edge cases in twttr, fuel, and bank modules
  • Refactored extensions.py to use dictionary lookup instead of if-else chains
  • Fixed a syntax error in outdated.py by changing elif to if

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pset5/twttr/test_twttr.py Added test case for string with spaces
pset5/fuel/test_fuel.py Added test case for 1/4 fraction conversion
pset5/bank/test_bank.py Added test case for greeting without 'h'
pset3/outdated.py Fixed syntax error by changing elif to if
pset1/extensions.py Added dictionary-based implementation for file extension handling
Comments suppressed due to low confidence (1)

pset1/extensions.py:37

  • The variable name 's' is ambiguous and unclear. Consider renaming it to 'extension' or 'file_extension' to better describe its purpose.
s = input("File name: ").strip().lower().split(".")[-1]

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@aviiciii aviiciii merged commit 4669912 into aviiciii:main Jul 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants