Skip to content

[bitnami/kafka] Add ClusterIP and loadBalancerNames check for using external access hosts list #34359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

moustafaomar
Copy link

Description of the change

This change solves the issue of using kafka with an nginx ingress with different hostnames and a fixed port. The change allows creating ClusterIP services for the external access, while enabling a different way for adding the hostnames using the loadBalancerNames.

Benefits

For restricted kubernetes implementations, where the user can only use a single port, the idea of having the domain field with ports that are automatically incremented doesn't work for the listeners.
This PR helps solve this issue by adding a condition for the service type being ClusterIP and the loadBalancerNames having the domain names, with the fixed port on ports.external.

Possible drawbacks

The only issue with this change is that it still marks the domain field as required for ClusterIP services.

Applicable issues

Additional information

To test the change:

  • Set externalAccess.controller.service.type and externalAccess.controller.broker.type to ClusterIP
  • Fill externalAccess.controller.service.domain and externalAccess.broker.service.domain with any values
  • Add externalAccess.controller.service.loadBalancerNames and externalAccess.broker.service.loadBalancerNames with the ingress hostnames.
  • Expected output: advertised.listeners on each pod gets EXTERNAL://hostname:port

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

…osts list

Signed-off-by: Mostafa Omar <moustafaomar200@gmail.com>
Signed-off-by: Mostafa Omar <moustafaomar200@gmail.com>
@github-actions github-actions bot added kafka triage Triage is needed labels Jun 11, 2025
@github-actions github-actions bot requested a review from carrodher June 11, 2025 20:16
Signed-off-by: Bitnami Bot <bitnami.bot@broadcom.com>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Jun 12, 2025
@github-actions github-actions bot removed the triage Triage is needed label Jun 12, 2025
@github-actions github-actions bot removed the request for review from carrodher June 12, 2025 11:05
@github-actions github-actions bot requested a review from alvneiayu June 12, 2025 11:05
bitnami-bot and others added 2 commits June 12, 2025 11:12
Signed-off-by: Bitnami Bot <bitnami.bot@broadcom.com>
Signed-off-by: Alvaro Neira Ayuso <alvaro.neira@broadcom.com>
@alvneiayu
Copy link
Contributor

Please, bump the version on the Chart.yaml.

Signed-off-by: Mostafa Omar <moustafaomar200@gmail.com>
@moustafaomar
Copy link
Author

Done, changed it to 32.2.17

Signed-off-by: Bitnami Bot <bitnami.bot@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress kafka verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[kafka] Unable to set correct advertised listeners for external access behind TCP Ingress
4 participants