[bitnami/kafka] Add ClusterIP and loadBalancerNames check for using external access hosts list #34359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This change solves the issue of using kafka with an nginx ingress with different hostnames and a fixed port. The change allows creating ClusterIP services for the external access, while enabling a different way for adding the hostnames using the loadBalancerNames.
Benefits
For restricted kubernetes implementations, where the user can only use a single port, the idea of having the domain field with ports that are automatically incremented doesn't work for the listeners.
This PR helps solve this issue by adding a condition for the service type being ClusterIP and the loadBalancerNames having the domain names, with the fixed port on ports.external.
Possible drawbacks
The only issue with this change is that it still marks the domain field as required for ClusterIP services.
Applicable issues
Additional information
To test the change:
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm