-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[PM-15159] Create SelfHostedOrganizationSignUp command #6089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[PM-15159] Create SelfHostedOrganizationSignUp command #6089
Conversation
Method extracted from OrganizationService
…rganizationSignUpCommand
…rvice and OrganizationService
New Issues (1)Checkmarx found the following issues in this Pull Request
Fixed Issues (4)Great job! The following issues were fixed in this Pull Request
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6089 +/- ##
==========================================
- Coverage 51.48% 48.30% -3.19%
==========================================
Files 1730 1728 -2
Lines 76302 76342 +40
Branches 6844 6821 -23
==========================================
- Hits 39287 36878 -2409
- Misses 35466 37979 +2513
+ Partials 1549 1485 -64 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally we break these up into separate files:
SelfHostedOrganizationSignUpRequest
SelfHostedOrganizationSignUpResult
ISelfHostedOrganizationSignUpCommand
SelfHostedOrganizationSignUpCommand
Personally, I'm fine with them being in the same file but I think the pattern is separate files for every class.
We can fix this later if we decide to make more improvements later.
33bdd2a
to
d24725d
Compare
…ISelfHostedOrganizationSignUpCommand interface to reflect nullable types for organizationUser and collectionName.
|
I've reverted back to having the full input parameters and the result tuple. I also moved the interface into its own file. I'll leave the |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15159
📔 Objective
Extract the method
SignUpAsync
fromOrganizationService
into a command.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes