Skip to content

Adds Workers Runtime team as codeowner for certain docs subdirs. #23028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025

Conversation

dom96
Copy link
Contributor

@dom96 dom96 commented Jun 13, 2025

We need more folks from the Runtime team to be able to review changes to these docs.

Copy link
Contributor

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/.github/CODEOWNERS @cloudflare/pcx-technical-writing

@dom96 dom96 enabled auto-merge (squash) June 13, 2025 17:41
Copy link
Contributor

github-actions bot commented Jun 13, 2025

@dom96
Copy link
Contributor Author

dom96 commented Jun 16, 2025

Looks like I need an approval from one of the assignees. Picking someone at random: @pedrosousa, can you take a look?

Copy link
Contributor

@kodster28 kodster28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of these are sorta duplicative. Can we consolidate to remove a lot of these paths, given that the above rule in https://github.com/cloudflare/cloudflare-docs/pull/23028/files#diff-3d36a1bf06148bc6ba1ce2ed3d19de32ea708d955fed212c0d27c536f0bd4da7R124 covers most of these paths?

/src/content/docs/workers/reference/migrate-to-module-workers.mdx @irvinebroque @GregBrimble @kodster28 @cloudflare/deploy-config @cloudflare/pcx-technical-writing
/src/content/docs/workers/reference/security-model.mdx @irvinebroque @GregBrimble @kodster28 @cloudflare/pcx-technical-writing
/src/content/docs/workers/runtime-apis/ @irvinebroque @jasnell @mikenomitch @GregBrimble @kodster28 @cloudflare/workers-runtime-1 @cloudflare/pcx-technical-writing
/src/content/docs/workers/runtime-apis/bindings/ @irvinebroque @mikenomitch @GregBrimble @kodster28 @cloudflare/workers-runtime-1 @cloudflare/pcx-technical-writing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need these if they're covered by the paths above

Copy link
Contributor

@kodster28 kodster28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed some of the duplicative entries to clean up the file

@dom96 dom96 merged commit 5f6b428 into production Jun 16, 2025
10 checks passed
@dom96 dom96 deleted the dominik/owners-fixes branch June 16, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants