-
Notifications
You must be signed in to change notification settings - Fork 6.9k
Adds Workers Runtime team as codeowner for certain docs subdirs. #23028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Preview URL: https://1f57a308.preview.developers.cloudflare.com |
Looks like I need an approval from one of the assignees. Picking someone at random: @pedrosousa, can you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of these are sorta duplicative. Can we consolidate to remove a lot of these paths, given that the above rule in https://github.com/cloudflare/cloudflare-docs/pull/23028/files#diff-3d36a1bf06148bc6ba1ce2ed3d19de32ea708d955fed212c0d27c536f0bd4da7R124 covers most of these paths?
.github/CODEOWNERS
Outdated
/src/content/docs/workers/reference/migrate-to-module-workers.mdx @irvinebroque @GregBrimble @kodster28 @cloudflare/deploy-config @cloudflare/pcx-technical-writing | ||
/src/content/docs/workers/reference/security-model.mdx @irvinebroque @GregBrimble @kodster28 @cloudflare/pcx-technical-writing | ||
/src/content/docs/workers/runtime-apis/ @irvinebroque @jasnell @mikenomitch @GregBrimble @kodster28 @cloudflare/workers-runtime-1 @cloudflare/pcx-technical-writing | ||
/src/content/docs/workers/runtime-apis/bindings/ @irvinebroque @mikenomitch @GregBrimble @kodster28 @cloudflare/workers-runtime-1 @cloudflare/pcx-technical-writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need these if they're covered by the paths above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed some of the duplicative entries to clean up the file
We need more folks from the Runtime team to be able to review changes to these docs.