[Spark][4.0] Add Delta Connect Scala Client integration test #4684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longvu-db
changed the title
xupefei
approved these changes
Jun 2, 2025
Comment on lines
+184
to
+187
| resolvers ++= Seq( | ||
| Resolver.mavenLocal, | ||
| "Delta" at "https://oss.sonatype.org/content/repositories/iodelta-1229" | ||
| ), |
There was a problem hiding this comment.
remove this this will be passed in as extraMavenRepo when run right? this means we don't need to update this when staging repo changes
Comment on lines
+179
to
+182
| libraryDependencies ++= Seq( | ||
| "io.delta" %% "delta-connect-client" % "4.0.0", | ||
| "org.apache.spark" %% "spark-connect-client-jvm" % "4.0.0" | ||
| ), |
There was a problem hiding this comment.
same thing here, can you use lookupSparkVersion like we do in getLibraryDependencies? So we don't need to update versions manually
There was a problem hiding this comment.
(and use getDeltaVersion for the delta-connect version)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Cherry-pick of #4628
How was this patch tested?
Does this PR introduce any user-facing changes?