[Kernel][#4] Introduce IcebergWriterCompatV3 #4774
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murali-db
force-pushed
the
introduce-writer-v3-validator
branch
from
f180378 to
11a6b7c
Compare
murali-db
changed the title
lzlfred
reviewed
Jun 18, 2025
| validateMaxRetriesSetToZero(transactionState); | ||
|
|
||
| /* ----- Validate this is valid write given the table's protocol & configurations ----- */ | ||
| checkState( |
There was a problem hiding this comment.
i think this is probably just borrowed from writer v1 but I wonder if we can put these checks on the table level instead of doing for each action.
There was a problem hiding this comment.
...io/delta/kernel/internal/icebergcompat/IcebergWriterCompatV3MetadataValidatorAndUpdater.java
Show resolved
Hide resolved
...io/delta/kernel/internal/icebergcompat/IcebergWriterCompatV3MetadataValidatorAndUpdater.java
Outdated
Show resolved
Hide resolved
vkorukanti
requested changes
Jun 18, 2025
| newProtocol.orElse(baseProtocol)); | ||
| if (icebergWriterCompatV3.isPresent()) { | ||
| newMetadata = icebergWriterCompatV3; | ||
| } |
There was a problem hiding this comment.
nit: can we move this and the above into IcebergWriterCompatMetadataValidatorAndUpdater.validateAndUpdateIcebergWriterCompatMetadata?
We should do the same of the icebergCompatV* as well.
| validateMaxRetriesSetToZero(transactionState); | ||
|
|
||
| /* ----- Validate this is valid write given the table's protocol & configurations ----- */ | ||
| checkState( |
There was a problem hiding this comment.
...nel-api/src/main/java/io/delta/kernel/internal/actions/GenerateIcebergCompatActionUtils.java
Outdated
Show resolved
Hide resolved
...io/delta/kernel/internal/icebergcompat/IcebergWriterCompatV3MetadataValidatorAndUpdater.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
How was this patch tested?
Unit tests.
Does this PR introduce any user-facing changes?
Yes. Introduces IcebergWriterCompatV3.