-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Kernel] [CatalogManaged] [UC] Simple UCCatalogManagedClient #4780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kernel] [CatalogManaged] [UC] Simple UCCatalogManagedClient #4780
Conversation
239d9a8 to
582b7ba
Compare
28a01d7 to
50b6668
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, looks great. left a few comments
18747e4 to
95c361c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
🥞 Stacked PR
Use this link to review incremental changes.
Which Delta project/connector is this regarding?
Description
Create a new jar
delta-unityand add aUCCatalogManagedClientinside of it, along with a simple test.More advanced tests will come soon (in future PRs).
How was this patch tested?
New simple unit test.
Does this PR introduce any user-facing changes?
No.