-
Notifications
You must be signed in to change notification settings - Fork 1k
Add code coverage for DataGridViewComboBoxColumn #13617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add code coverage for DataGridViewComboBoxColumn #13617
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13617 +/- ##
===================================================
+ Coverage 76.58723% 76.83288% +0.24564%
===================================================
Files 3253 3257 +4
Lines 640992 642471 +1479
Branches 47439 47572 +133
===================================================
+ Hits 490918 493629 +2711
+ Misses 146541 145182 -1359
- Partials 3533 3660 +127
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxColumnTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxColumnTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxColumnTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxColumnTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxColumnTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxColumnTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxColumnTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small comments, please check other tests
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxColumnTests.cs
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxColumnTests.cs
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxColumnTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxColumnTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxColumnTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxColumnTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxColumnTests.cs
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxColumnTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxColumnTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxColumnTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxColumnTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxColumnTests.cs
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxColumnTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxColumnTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxColumnTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxColumnTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxColumnTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxColumnTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxColumnTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxColumnTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxColumnTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxColumnTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a little suggestion
Related #13442
Proposed changes
Add unit test file:DataGridViewComboBoxColumnTest.cs for public methods of the DataGridViewComboBoxColumn.cs
Microsoft Reviewers: Open in CodeFlow