Skip to content

Add code coverage for DataGridViewComboBoxColumn #13617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Jun 18, 2025

Related #13442

Proposed changes

Add unit test file:DataGridViewComboBoxColumnTest.cs for public methods of the DataGridViewComboBoxColumn.cs

Microsoft Reviewers: Open in CodeFlow

@Zheng-Li01 Zheng-Li01 requested a review from a team as a code owner June 18, 2025 09:10
@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Jun 18, 2025
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

Attention: Patch coverage is 99.65753% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.83288%. Comparing base (ece6f6d) to head (617496c).
Report is 31 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13617         +/-   ##
===================================================
+ Coverage   76.58723%   76.83288%   +0.24564%     
===================================================
  Files           3253        3257          +4     
  Lines         640992      642471       +1479     
  Branches       47439       47572        +133     
===================================================
+ Hits          490918      493629       +2711     
+ Misses        146541      145182       -1359     
- Partials        3533        3660        +127     
Flag Coverage Δ
Debug 76.83288% <99.65753%> (+0.24564%) ⬆️
integration 18.99490% <ø> (+0.51274%) ⬆️
production 51.45490% <ø> (+0.43315%) ⬆️
test 97.41965% <99.65753%> (+0.00790%) ⬆️
unit 48.83145% <ø> (+0.39951%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LeafShi1 LeafShi1 requested a review from Copilot June 19, 2025 07:16
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@dotnet-policy-service dotnet-policy-service bot added the waiting-author-feedback The team requires more information from the author label Jun 21, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jun 23, 2025
Copy link
Member

@LeafShi1 LeafShi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments, please check other tests

ricardobossan
ricardobossan previously approved these changes Jul 4, 2025
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

ricardobossan
ricardobossan previously approved these changes Jul 5, 2025
Copy link
Member

@LeafShi1 LeafShi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a little suggestion

ricardobossan
ricardobossan previously approved these changes Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-test coverage waiting-review This item is waiting on review by one or more members of team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants