Skip to content

Large route table with hmap #5589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Large route table with hmap #5589

wants to merge 1 commit into from
+695 −108

Conversation

hewang-jump
Copy link
Contributor

No description provided.

@hewang-jump hewang-jump force-pushed the hewangintern/fib4-hmap branch from 606ba62 to 2b0e28b Compare July 8, 2025 23:17
ripatel-fd
ripatel-fd reviewed Jul 8, 2025
View reviewed changes
ripatel-fd
ripatel-fd reviewed Jul 8, 2025
View reviewed changes
ripatel-fd
ripatel-fd reviewed Jul 8, 2025
View reviewed changes
ripatel-fd
ripatel-fd reviewed Jul 8, 2025
View reviewed changes
ripatel-fd
ripatel-fd reviewed Jul 8, 2025
View reviewed changes
@hewang-jump hewang-jump force-pushed the hewangintern/fib4-hmap branch 7 times, most recently from fe5417d to 9b00d00 Compare July 9, 2025 16:00
ripatel-fd
ripatel-fd reviewed Jul 9, 2025
View reviewed changes
ripatel-fd
ripatel-fd reviewed Jul 9, 2025
View reviewed changes
ripatel-fd
ripatel-fd reviewed Jul 9, 2025
View reviewed changes
@hewang-jump hewang-jump force-pushed the hewangintern/fib4-hmap branch 4 times, most recently from aa3496d to 929b1fd Compare July 9, 2025 19:15
ripatel-fd
ripatel-fd reviewed Jul 9, 2025
View reviewed changes
ripatel-fd
ripatel-fd reviewed Jul 9, 2025
View reviewed changes
ripatel-fd
ripatel-fd reviewed Jul 9, 2025
View reviewed changes
@hewang-jump hewang-jump force-pushed the hewangintern/fib4-hmap branch 7 times, most recently from 9253821 to 2e5169e Compare July 10, 2025 14:33
@hewang-jump hewang-jump force-pushed the hewangintern/fib4-hmap branch 11 times, most recently from bd8f3b2 to b3f3454 Compare July 11, 2025 18:22
@hewang-jump hewang-jump force-pushed the hewangintern/fib4-hmap branch from b3f3454 to a46da56 Compare July 11, 2025 18:28
ripatel-fd
ripatel-fd reviewed Jul 12, 2025
View reviewed changes
src/app/fdctl/config/default.toml
Comment on lines +1026 to +1031
# This configures the number of locks for concurrent access to the IPv4
# /32 route table (see above). Each lock protects roughly
# max_peer_routes/lock_cnt route entries. Higher values improve
# parallelism for concurrent operations but increase memory overhead.
# Adjust based on expected concurrency level (typically 16-1024).
lock_cnt_peer_routes = 32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty technical, so I wouldn't expose this to our users.
Could you remove this config option and instead choose a default based on the route table size in the obj_callback code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripatel-fd ripatel-fd ripatel-fd left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hewang-jump @ripatel-fd