replay: better locks around banks #5622
Open
+33
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibhatt-jumptrading
force-pushed
the
ibhatt/better_locking_banks
branch
from
ab79715 to
4f99d62
Compare
ibhatt-jumptrading
changed the title
ibhatt-jumptrading
force-pushed
the
ibhatt/better_locking_banks
branch
from
4f99d62 to
c434cf8
Compare
ibhatt-jumptrading
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we need locks in the exec and writer tiles around uses of the bank. This is to avoid the replay tile releasing a bank that is currently being used in the exec and writer tiles. This is not needed in the replay tile because we have an invariant that the current slot that's being executed will not be rooted