Skip to content

Added feature of Meridiem Time. Should work on both modes. #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

cronopio
Copy link

@cronopio cronopio commented Aug 30, 2019

By far code is ready to review and testing. So far looks good. Will need deep testing.

Any comments or feedback is well received.

Daniel Aristizabal and others added 9 commits August 20, 2019 17:24
Set a radius half  if it has innerClock if not setting a entire Radius
validate if is innerClock when the hour is < that 12 without meridiem
update the time adding meridiem am. and pm. to return the time
It's to the case if the meridiem flag is comming in options but the time has not the meridiem value
@cronopio cronopio changed the title Added feature of Meridiam Time. Should work on both modes. Added feature of Meridiem Time. Should work on both modes. Aug 30, 2019
@cronopio
Copy link
Author

Not ready to merge. Just ready to testing

@cronopio
Copy link
Author

cronopio commented Sep 3, 2019

Added also possibility to override text label on buttons, you can set your own text for OK button and Cancel button.
Already Tested, please test on your own projects and give us some feedback.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants