-
Notifications
You must be signed in to change notification settings - Fork 2
Added feature of Meridiem Time. Should work on both modes. #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cronopio
wants to merge
13
commits into
grudus:master
Choose a base branch
from
arodrigueze0215:cronopio
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set a radius half if it has innerClock if not setting a entire Radius
validate if is innerClock when the hour is < that 12 without meridiem
update the time adding meridiem am. and pm. to return the time
It's to the case if the meridiem flag is comming in options but the time has not the meridiem value
Not ready to merge. Just ready to testing |
Added also possibility to override text label on buttons, you can set your own text for OK button and Cancel button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By far code is ready to review and testing. So far looks good. Will need deep testing.
Any comments or feedback is well received.