Skip to content

Add resource identity to aws_lb_target_group #43171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2025
Merged

Add resource identity to aws_lb_target_group #43171

merged 3 commits into from
Jul 22, 2025

Conversation

breathingdust
Copy link
Member

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Adds resource identity to aws_lb_target_group. This is of type ArnIdentity

Relations

Relates #42984

References

Output from Acceptance Testing

make testacc TESTS=TestAccELBV2TargetGroup_ PKG=elbv2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.4 test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccELBV2TargetGroup_'  -timeout 360m -vet=off
2025/06/24 14:25:09 Creating Terraform AWS Provider (SDKv2-style)...
2025/06/24 14:25:09 Initializing Terraform AWS Provider (SDKv2-style)...
--- PASS: TestAccELBV2TargetGroup_Lambda_HealthCheck_matcherOutOfRange (12.48s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_InvalidSlowStart (17.74s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_InvalidAnomalyMitigation (31.73s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_generatedName (37.06s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_namePrefix (37.16s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_lambda (41.50s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_changeVPCForceNew (54.24s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_changeProtocolForceNew (62.97s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_setAndUpdateSlowStart (65.96s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_basic (35.12s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_validALB (68.98s)
--- PASS: TestAccELBV2TargetGroup_targetHealthStateUnhealthyDrainInterval (68.98s)
--- PASS: TestAccELBV2TargetGroup_ForceNew_name (69.01s)
--- PASS: TestAccELBV2TargetGroup_HealthCheck_without (33.84s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_changePortForceNew (59.60s)
--- PASS: TestAccELBV2TargetGroup_Identity_Basic (74.62s)
--- PASS: TestAccELBV2TargetGroup_Lambda_HealthCheck_basic_MigrateV0 (76.15s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_changeNameForceNew (64.04s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_updateStickinessEnabled (81.88s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_lambdaMultiValueHeadersEnabled (89.20s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingAnomalyMitigation (90.16s)
--- PASS: TestAccELBV2TargetGroup_tags_ComputedTag_OnUpdate_Add (91.05s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingCrossZoneEnabled (92.24s)
--- PASS: TestAccELBV2TargetGroup_HealthCheck_update (61.81s)
--- PASS: TestAccELBV2TargetGroup_backwardsCompatibility (32.94s)
--- PASS: TestAccELBV2TargetGroup_tags_DefaultTags_emptyProviderOnlyTag (50.41s)
--- PASS: TestAccELBV2TargetGroup_udp (32.37s)
--- PASS: TestAccELBV2TargetGroup_tags_DefaultTags_nullNonOverlappingResourceTag (52.93s)
--- PASS: TestAccELBV2TargetGroup_tags_DefaultTags_emptyResourceTag (49.86s)
--- PASS: TestAccELBV2TargetGroup_tags_DefaultTags_nullOverlappingResourceTag (52.93s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_updateEnabled (89.03s)
--- PASS: TestAccELBV2TargetGroup_tags_ComputedTag_OnCreate (58.22s)
--- PASS: TestAccELBV2TargetGroup_tls (35.41s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_updateStickinessType (89.33s)
--- PASS: TestAccELBV2TargetGroup_targetGroupHealthState (146.13s)
--- PASS: TestAccELBV2TargetGroup_ipAddressType (46.19s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_updateAppEnabled (89.28s)
--- PASS: TestAccELBV2TargetGroup_attrsOnCreate (64.28s)
--- PASS: TestAccELBV2TargetGroup_tags_DefaultTags_updateToResourceOnly (81.25s)
--- PASS: TestAccELBV2TargetGroup_Lambda_vpc (36.47s)
--- PASS: TestAccELBV2TargetGroup_tags_DefaultTags_updateToProviderOnly (82.63s)
--- PASS: TestAccELBV2TargetGroup_HealthCheck_tcpHTTPS (67.98s)
--- PASS: TestAccELBV2TargetGroup_ProtocolVersion_grpcHealthCheck (37.72s)
--- PASS: TestAccELBV2TargetGroup_ProtocolVersion_grpcUpdate (60.90s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_validNLB (116.43s)
--- PASS: TestAccELBV2TargetGroup_Lambda_defaults (30.17s)
--- PASS: TestAccELBV2TargetGroup_ProtocolVersion_basic (65.41s)
--- PASS: TestAccELBV2TargetGroup_tags_DefaultTags_nonOverlapping (133.55s)
--- PASS: TestAccELBV2TargetGroup_Lambda_defaults_MigrateV0 (80.22s)
--- PASS: TestAccELBV2TargetGroup_tags_AddOnUpdate (78.70s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_invalidNLB (50.66s)
--- PASS: TestAccELBV2TargetGroup_tags_DefaultTags_overlapping (129.14s)
--- PASS: TestAccELBV2TargetGroup_Lambda_vpc_MigrateV0 (90.04s)
--- PASS: TestAccELBV2TargetGroup_tags_null (61.85s)
--- PASS: TestAccELBV2TargetGroup_tags_EmptyMap (61.13s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_updateHealthCheck (62.21s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_defaultALB (35.06s)
--- PASS: TestAccELBV2TargetGroup_preserveClientIPValid (65.18s)
--- PASS: TestAccELBV2TargetGroup_tags_EmptyTag_OnUpdate_Replace (84.47s)
--- PASS: TestAccELBV2TargetGroup_tags_EmptyTag_OnCreate (83.08s)
--- PASS: TestAccELBV2TargetGroup_targetHealthStateUnhealthyConnectionTermination (114.66s)
--- PASS: TestAccELBV2TargetGroup_disappears (36.45s)
--- PASS: TestAccELBV2TargetGroup_Geneve_basic (44.24s)
--- PASS: TestAccELBV2TargetGroup_duplicateName (46.34s)
--- PASS: TestAccELBV2TargetGroup_nameGenerated (46.26s)
--- PASS: TestAccELBV2TargetGroup_namePrefix (48.64s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_invalidALB (85.13s)
--- PASS: TestAccELBV2TargetGroup_Geneve_Sticky (62.12s)
--- PASS: TestAccELBV2TargetGroup_Lambda_port (30.22s)
--- PASS: TestAccELBV2TargetGroup_Geneve_notSticky (61.65s)
--- PASS: TestAccELBV2TargetGroup_Geneve_targetFailover (78.18s)
--- PASS: TestAccELBV2TargetGroup_basic (46.58s)
--- PASS: TestAccELBV2TargetGroup_tags_EmptyTag_OnUpdate_Add (123.29s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_defaultNLB (87.63s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingAlgorithmType (112.86s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_tags (58.90s)
--- PASS: TestAccELBV2TargetGroup_Defaults_network (35.88s)
--- PASS: TestAccELBV2TargetGroup_Defaults_application (36.47s)
--- PASS: TestAccELBV2TargetGroup_Lambda_protocolVersion (34.38s)
--- PASS: TestAccELBV2TargetGroup_Lambda_protocolVersion_MigrateV0 (79.79s)
--- PASS: TestAccELBV2TargetGroup_Lambda_HealthCheck_basic (32.57s)
--- PASS: TestAccELBV2TargetGroup_tags_DefaultTags_providerOnly (181.06s)
--- PASS: TestAccELBV2TargetGroup_Lambda_port_MigrateV0 (81.01s)
--- PASS: TestAccELBV2TargetGroup_HealthCheck_enable (63.21s)
--- PASS: TestAccELBV2TargetGroup_networkLB_TargetGroupWithConnectionTermination (63.81s)
--- PASS: TestAccELBV2TargetGroup_NetworkLB_targetGroupWithProxy (67.54s)
--- PASS: TestAccELBV2TargetGroup_NetworkLB_tcpHealthCheckUpdated (64.29s)
--- PASS: TestAccELBV2TargetGroup_ForceNew_vpc (62.40s)
--- PASS: TestAccELBV2TargetGroup_Lambda_HealthCheck_protocol (0.00s)
    --- PASS: TestAccELBV2TargetGroup_Lambda_HealthCheck_protocol/TCP (3.80s)
    --- PASS: TestAccELBV2TargetGroup_Lambda_HealthCheck_protocol/HTTP (30.78s)
    --- PASS: TestAccELBV2TargetGroup_Lambda_HealthCheck_protocol/HTTPS (38.40s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_missing (0.00s)
    --- PASS: TestAccELBV2TargetGroup_ALBAlias_missing/Port (6.99s)
    --- PASS: TestAccELBV2TargetGroup_ALBAlias_missing/VPC (6.45s)
    --- PASS: TestAccELBV2TargetGroup_ALBAlias_missing/Protocol (5.43s)
--- PASS: TestAccELBV2TargetGroup_ForceNew_port (66.76s)
--- PASS: TestAccELBV2TargetGroup_ForceNew_protocol (72.03s)
--- PASS: TestAccELBV2TargetGroup_tags_IgnoreTags_Overlap_ResourceTag (131.77s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGeneve_defaults (0.00s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGeneve_defaults/HTTP (38.35s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGeneve_defaults/TCP (36.04s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGeneve_defaults/HTTPS (43.60s)
--- PASS: TestAccELBV2TargetGroup_tags_IgnoreTags_Overlap_DefaultTag (112.30s)
--- PASS: TestAccELBV2TargetGroup_Lambda_protocol (0.00s)
    --- PASS: TestAccELBV2TargetGroup_Lambda_protocol/TCP_UDP (30.78s)
    --- PASS: TestAccELBV2TargetGroup_Lambda_protocol/HTTP (33.02s)
    --- PASS: TestAccELBV2TargetGroup_Lambda_protocol/TLS (32.84s)
    --- PASS: TestAccELBV2TargetGroup_Lambda_protocol/TCP (29.80s)
    --- PASS: TestAccELBV2TargetGroup_Lambda_protocol/HTTPS (28.54s)
    --- PASS: TestAccELBV2TargetGroup_Lambda_protocol/UDP (34.89s)
    --- PASS: TestAccELBV2TargetGroup_Lambda_protocol/GENEVE (35.21s)
--- PASS: TestAccELBV2TargetGroup_tags_ComputedTag_OnUpdate_Replace (100.25s)
--- PASS: TestAccELBV2TargetGroup_Identity_RegionOverride (106.31s)
--- PASS: TestAccELBV2TargetGroup_Lambda_HealthCheck_protocol_MigrateV0 (0.00s)
    --- PASS: TestAccELBV2TargetGroup_Lambda_HealthCheck_protocol_MigrateV0/TCP (34.50s)
    --- PASS: TestAccELBV2TargetGroup_Lambda_HealthCheck_protocol_MigrateV0/HTTP (71.53s)
    --- PASS: TestAccELBV2TargetGroup_Lambda_HealthCheck_protocol_MigrateV0/HTTPS (82.62s)
--- PASS: TestAccELBV2TargetGroup_Instance_protocolVersion (0.00s)
    --- PASS: TestAccELBV2TargetGroup_Instance_protocolVersion/TLS (34.07s)
    --- PASS: TestAccELBV2TargetGroup_Instance_protocolVersion/HTTP (39.97s)
    --- PASS: TestAccELBV2TargetGroup_Instance_protocolVersion/TCP_UDP (33.14s)
    --- PASS: TestAccELBV2TargetGroup_Instance_protocolVersion/UDP (34.88s)
    --- PASS: TestAccELBV2TargetGroup_Instance_protocolVersion/TCP (34.74s)
    --- PASS: TestAccELBV2TargetGroup_Instance_protocolVersion/HTTPS (34.88s)
--- PASS: TestAccELBV2TargetGroup_tags (163.35s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_defaults (0.00s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_defaults/HTTP (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_defaults/HTTP/TCP (1.64s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_defaults/HTTP/HTTPS (21.37s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_defaults/HTTP/HTTP (21.24s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_defaults/HTTPS (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_defaults/HTTPS/TCP (1.73s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_defaults/HTTPS/HTTP (23.14s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_defaults/HTTPS/HTTPS (24.03s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange (0.00s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/HTTP (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/HTTP/HTTP (13.18s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/HTTP/TCP (1.55s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/HTTP/HTTPS (10.86s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/UDP (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/UDP/HTTP (12.28s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/UDP/TCP (1.84s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/UDP/HTTPS (15.17s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/TCP_UDP (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/TCP_UDP/TCP (2.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/TCP_UDP/HTTP (14.98s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/TCP_UDP/HTTPS (15.37s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/TCP (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/TCP/TCP (1.72s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/TCP/HTTP (15.17s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/TCP/HTTPS (15.69s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/TLS (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/TLS/TCP (1.96s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/TLS/HTTP (14.75s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/TLS/HTTPS (13.91s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/HTTPS (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/HTTPS/TCP (2.76s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/HTTPS/HTTP (15.82s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange/HTTPS/HTTPS (13.81s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_matcherOutOfRange (0.00s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_matcherOutOfRange/HTTP (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_matcherOutOfRange/HTTP/TCP (3.68s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_matcherOutOfRange/HTTP/HTTP (15.22s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_matcherOutOfRange/HTTP/HTTPS (17.91s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_matcherOutOfRange/HTTPS (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_matcherOutOfRange/HTTPS/TCP (1.92s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_matcherOutOfRange/HTTPS/HTTP (16.19s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_matcherOutOfRange/HTTPS/HTTPS (18.08s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_path (0.00s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_path/HTTP (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_path/HTTP/TCP (2.63s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_path/HTTP/HTTP (28.49s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_path/HTTP/HTTPS (29.03s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_path/HTTPS (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_path/HTTPS/TCP (3.58s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_path/HTTPS/HTTP (35.51s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_path/HTTPS/HTTPS (31.26s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path (0.00s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/HTTP (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/HTTP/TCP (3.59s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/HTTP/HTTP (36.93s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/HTTP/HTTPS (35.24s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/UDP (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/UDP/TCP (5.21s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/UDP/HTTP (30.73s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/UDP/HTTPS (30.86s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/HTTPS (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/HTTPS/TCP (3.14s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/HTTPS/HTTP (34.50s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/HTTPS/HTTPS (33.97s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/TCP_UDP (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/TCP_UDP/TCP (1.89s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/TCP_UDP/HTTP (27.91s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/TCP_UDP/HTTPS (34.45s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/TCP (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/TCP/TCP (2.18s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/TCP/HTTP (30.48s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/TCP/HTTPS (28.21s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/TLS (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/TLS/TCP (2.23s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/TLS/HTTP (30.02s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_path/TLS/HTTPS (34.36s)
--- PASS: TestAccELBV2TargetGroup_Instance_protocolVersion_MigrateV0 (0.00s)
    --- PASS: TestAccELBV2TargetGroup_Instance_protocolVersion_MigrateV0/UDP (133.99s)
    --- PASS: TestAccELBV2TargetGroup_Instance_protocolVersion_MigrateV0/TLS (139.99s)
    --- PASS: TestAccELBV2TargetGroup_Instance_protocolVersion_MigrateV0/TCP (159.67s)
    --- PASS: TestAccELBV2TargetGroup_Instance_protocolVersion_MigrateV0/HTTP (168.26s)
    --- PASS: TestAccELBV2TargetGroup_Instance_protocolVersion_MigrateV0/HTTPS (194.36s)
    --- PASS: TestAccELBV2TargetGroup_Instance_protocolVersion_MigrateV0/TCP_UDP (213.02s)
--- PASS: TestAccELBV2TargetGroup_Lambda_protocol_MigrateV0 (0.00s)
    --- PASS: TestAccELBV2TargetGroup_Lambda_protocol_MigrateV0/HTTPS (109.14s)
    --- PASS: TestAccELBV2TargetGroup_Lambda_protocol_MigrateV0/GENEVE (160.87s)
    --- PASS: TestAccELBV2TargetGroup_Lambda_protocol_MigrateV0/TCP_UDP (171.51s)
    --- PASS: TestAccELBV2TargetGroup_Lambda_protocol_MigrateV0/TCP (173.30s)
    --- PASS: TestAccELBV2TargetGroup_Lambda_protocol_MigrateV0/HTTP (202.18s)
    --- PASS: TestAccELBV2TargetGroup_Lambda_protocol_MigrateV0/UDP (203.05s)
    --- PASS: TestAccELBV2TargetGroup_Lambda_protocol_MigrateV0/TLS (187.34s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults (0.00s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/HTTP (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/HTTP/TCP (3.32s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/HTTP/HTTP (29.94s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/HTTP/HTTPS (32.42s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/TCP_UDP (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/TCP_UDP/HTTP (34.49s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/TCP_UDP/TCP (31.57s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/TCP_UDP/HTTPS (34.00s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/UDP (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/UDP/HTTP (34.54s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/UDP/TCP (35.20s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/UDP/HTTPS (33.80s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/TLS (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/TLS/HTTP (34.39s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/TLS/TCP (38.18s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/TLS/HTTPS (38.42s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/HTTPS (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/HTTPS/TCP (4.12s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/HTTPS/HTTP (34.06s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/HTTPS/HTTPS (31.08s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/TCP (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/TCP/HTTP (33.26s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/TCP/HTTPS (34.36s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_defaults/TCP/TCP (36.15s)
--- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher (0.00s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/HTTP (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/HTTP/TCP (4.78s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/HTTP/HTTP (31.35s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/HTTP/HTTPS (31.06s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/UDP (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/UDP/TCP (3.57s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/UDP/HTTP (30.69s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/UDP/HTTPS (30.26s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/TCP_UDP (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/TCP_UDP/TCP (4.58s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/TCP_UDP/HTTP (27.85s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/TCP_UDP/HTTPS (26.43s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/TCP (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/TCP/TCP (4.70s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/TCP/HTTP (24.71s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/TCP/HTTPS (24.67s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/TLS (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/TLS/TCP (4.34s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/TLS/HTTP (24.87s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/TLS/HTTPS (21.67s)
    --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/HTTPS (0.00s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/HTTPS/TCP (3.97s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/HTTPS/HTTP (20.86s)
        --- PASS: TestAccELBV2TargetGroup_Instance_HealthCheck_matcher/HTTPS/HTTPS (20.06s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	583.043s

...

Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/elbv2 Issues and PRs that pertain to the elbv2 service. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Jun 24, 2025
@breathingdust breathingdust marked this pull request as ready for review June 24, 2025 22:15
@breathingdust breathingdust requested a review from a team as a code owner June 24, 2025 22:15
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have an ExistingResource test such as the tests added in #43221. Unfortunately, they cannot be generated.

jar-b
jar-b previously approved these changes Jul 17, 2025
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=elbv2 TESTS=TestAccELBV2TargetGroup_Identity
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccELBV2TargetGroup_Identity'  -timeout 360m -vet=off
2025/07/17 15:28:56 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/17 15:28:56 Initializing Terraform AWS Provider (SDKv2-style)...

--- PASS: TestAccELBV2TargetGroup_Identity_Basic (40.57s)
--- PASS: TestAccELBV2TargetGroup_Identity_RegionOverride (41.54s)
--- PASS: TestAccELBV2TargetGroup_Identity_ExistingResource (57.47s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elbv2      63.571s

breathingdust and others added 3 commits July 22, 2025 11:36
```console
% make testacc PKG=elbv2 TESTS=TestAccELBV2TargetGroup_Identity
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccELBV2TargetGroup_Identity'  -timeout 360m -vet=off
2025/07/17 15:28:56 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/17 15:28:56 Initializing Terraform AWS Provider (SDKv2-style)...

--- PASS: TestAccELBV2TargetGroup_Identity_Basic (40.57s)
--- PASS: TestAccELBV2TargetGroup_Identity_RegionOverride (41.54s)
--- PASS: TestAccELBV2TargetGroup_Identity_ExistingResource (57.47s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elbv2      63.571s
```
@jar-b jar-b force-pushed the f-ri-lb-target-group branch from ca3c915 to 25aa8ea Compare July 22, 2025 15:37
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@jar-b jar-b dismissed gdavison’s stale review July 22, 2025 19:07

Requested changes have been addressed.

@jar-b jar-b merged commit b77b9c7 into main Jul 22, 2025
62 checks passed
@jar-b jar-b deleted the f-ri-lb-target-group branch July 22, 2025 19:07
Copy link

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.5.0 milestone Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants