-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Add resource identity to aws_lb_target_group
#43171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have an ExistingResource
test such as the tests added in #43221. Unfortunately, they cannot be generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc PKG=elbv2 TESTS=TestAccELBV2TargetGroup_Identity
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccELBV2TargetGroup_Identity' -timeout 360m -vet=off
2025/07/17 15:28:56 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/17 15:28:56 Initializing Terraform AWS Provider (SDKv2-style)...
--- PASS: TestAccELBV2TargetGroup_Identity_Basic (40.57s)
--- PASS: TestAccELBV2TargetGroup_Identity_RegionOverride (41.54s)
--- PASS: TestAccELBV2TargetGroup_Identity_ExistingResource (57.47s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elbv2 63.571s
```console % make testacc PKG=elbv2 TESTS=TestAccELBV2TargetGroup_Identity make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.24.5 test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccELBV2TargetGroup_Identity' -timeout 360m -vet=off 2025/07/17 15:28:56 Creating Terraform AWS Provider (SDKv2-style)... 2025/07/17 15:28:56 Initializing Terraform AWS Provider (SDKv2-style)... --- PASS: TestAccELBV2TargetGroup_Identity_Basic (40.57s) --- PASS: TestAccELBV2TargetGroup_Identity_RegionOverride (41.54s) --- PASS: TestAccELBV2TargetGroup_Identity_ExistingResource (57.47s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/elbv2 63.571s ```
ca3c915
to
25aa8ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Description
Adds resource identity to
aws_lb_target_group
. This is of typeArnIdentity
Relations
Relates #42984
References
Output from Acceptance Testing