Skip to content

Add resource identity to aws_lb_trust_store #43186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add resource identity to aws_lb_trust_store #43186

wants to merge 3 commits into from
+578 −4

Conversation

breathingdust
Copy link
Member

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Adds resource identity to aws_lb_trust_store. This is of type ArnIdentity

Relations

Relates #42984

References

Output from Acceptance Testing

make testacc TESTS=TestAccELBV2TrustStore_ PKG=elbv2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.4 test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccELBV2TrustStore_'  -timeout 360m -vet=off
2025/06/25 12:50:04 Creating Terraform AWS Provider (SDKv2-style)...
2025/06/25 12:50:05 Initializing Terraform AWS Provider (SDKv2-style)...
--- PASS: TestAccELBV2TrustStore_disappears (66.77s)
--- PASS: TestAccELBV2TrustStore_nameGenerated (67.81s)
--- PASS: TestAccELBV2TrustStore_basic (69.84s)
--- PASS: TestAccELBV2TrustStore_namePrefix (69.92s)
--- PASS: TestAccELBV2TrustStore_tags_DefaultTags_emptyResourceTag (77.72s)
--- PASS: TestAccELBV2TrustStore_tags_null (85.05s)
--- PASS: TestAccELBV2TrustStore_Identity_Basic (93.17s)
--- PASS: TestAccELBV2TrustStore_tags_AddOnUpdate (99.19s)
--- PASS: TestAccELBV2TrustStore_tags_DefaultTags_updateToResourceOnly (102.18s)
--- PASS: TestAccELBV2TrustStore_tags_EmptyTag_OnCreate (104.53s)
--- PASS: TestAccELBV2TrustStore_tags_EmptyMap (104.95s)
--- PASS: TestAccELBV2TrustStore_Identity_RegionOverride (114.86s)
--- PASS: TestAccELBV2TrustStore_tags_IgnoreTags_Overlap_ResourceTag (121.31s)
--- PASS: TestAccELBV2TrustStore_tags_EmptyTag_OnUpdate_Add (125.25s)
--- PASS: TestAccELBV2TrustStore_tags_ComputedTag_OnCreate (127.99s)
--- PASS: TestAccELBV2TrustStore_tags_DefaultTags_overlapping (135.17s)
--- PASS: TestAccELBV2TrustStore_tags_DefaultTags_nullOverlappingResourceTag (63.20s)
--- PASS: TestAccELBV2TrustStore_tags_DefaultTags_nullNonOverlappingResourceTag (61.51s)
--- PASS: TestAccELBV2TrustStore_tags_IgnoreTags_Overlap_DefaultTag (147.49s)
--- PASS: TestAccELBV2TrustStore_tags_DefaultTags_updateToProviderOnly (83.50s)
--- PASS: TestAccELBV2TrustStore_tags (151.74s)
--- PASS: TestAccELBV2TrustStore_tags_DefaultTags_emptyProviderOnlyTag (58.99s)
--- PASS: TestAccELBV2TrustStore_tags_ComputedTag_OnUpdate_Replace (84.36s)
--- PASS: TestAccELBV2TrustStore_tags_EmptyTag_OnUpdate_Replace (82.28s)
--- PASS: TestAccELBV2TrustStore_tags_ComputedTag_OnUpdate_Add (84.27s)
--- PASS: TestAccELBV2TrustStore_tags_DefaultTags_nonOverlapping (159.73s)
--- PASS: TestAccELBV2TrustStore_tags_DefaultTags_providerOnly (172.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	177.943s

@breathingdust breathingdust requested a review from a team as a code owner June 25, 2025 21:10
@github-actions GitHub Actions
Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/elbv2 Issues and PRs that pertain to the elbv2 service. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. labels Jun 25, 2025
gdavison
gdavison approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

--- PASS: TestAccELBV2TrustStore_disappears (74.20s)
--- PASS: TestAccELBV2TrustStore_namePrefix (75.98s)
--- PASS: TestAccELBV2TrustStore_basic (80.23s)
--- PASS: TestAccELBV2TrustStore_tags_DefaultTags_emptyResourceTag (80.55s)
--- PASS: TestAccELBV2TrustStore_nameGenerated (83.69s)
--- PASS: TestAccELBV2TrustStore_tags_DefaultTags_nullOverlappingResourceTag (86.10s)
--- PASS: TestAccELBV2TrustStore_tags_ComputedTag_OnCreate (89.34s)
--- PASS: TestAccELBV2TrustStore_Identity_Basic (108.78s)
--- PASS: TestAccELBV2TrustStore_tags_DefaultTags_updateToProviderOnly (111.35s)
--- PASS: TestAccELBV2TrustStore_tags_EmptyTag_OnCreate (112.12s)
--- PASS: TestAccELBV2TrustStore_tags_ComputedTag_OnUpdate_Add (113.71s)
--- PASS: TestAccELBV2TrustStore_tags_IgnoreTags_Overlap_DefaultTag (122.80s)
--- PASS: TestAccELBV2TrustStore_tags_EmptyMap (128.10s)
--- PASS: TestAccELBV2TrustStore_tags_EmptyTag_OnUpdate_Add (132.95s)
--- PASS: TestAccELBV2TrustStore_tags_IgnoreTags_Overlap_ResourceTag (137.17s)
--- PASS: TestAccELBV2TrustStore_tags_DefaultTags_updateToResourceOnly (140.62s)
--- PASS: TestAccELBV2TrustStore_tags_ComputedTag_OnUpdate_Replace (142.07s)
--- PASS: TestAccELBV2TrustStore_tags_DefaultTags_overlapping (143.94s)
--- PASS: TestAccELBV2TrustStore_tags_null (72.86s)
--- PASS: TestAccELBV2TrustStore_tags_DefaultTags_nullNonOverlappingResourceTag (66.22s)
--- PASS: TestAccELBV2TrustStore_tags (160.17s)
--- PASS: TestAccELBV2TrustStore_tags_EmptyTag_OnUpdate_Replace (77.84s)
--- PASS: TestAccELBV2TrustStore_tags_AddOnUpdate (76.18s)
--- PASS: TestAccELBV2TrustStore_Identity_RegionOverride (93.00s)
--- PASS: TestAccELBV2TrustStore_tags_DefaultTags_emptyProviderOnlyTag (178.26s)
--- PASS: TestAccELBV2TrustStore_tags_DefaultTags_nonOverlapping (103.43s)
--- PASS: TestAccELBV2TrustStore_tags_DefaultTags_providerOnly (118.89s)

gdavison
gdavison requested changes Jul 4, 2025
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have an ExistingResource test such as the tests added in #43221. Unfortunately, they cannot be generated.

jar-b added 2 commits July 17, 2025 15:35
@jar-b
Merge branch 'main' into f-ri-lb-trust-store
8b1b730
@jar-b
r/aws_lb_trust_store: re-generate identity tests
c743df7 
```console
% make testacc PKG=elbv2 TESTS=TestAccELBV2TrustStore_Identity
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccELBV2TrustStore_Identity'  -timeout 360m -vet=off
2025/07/17 15:44:01 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/17 15:44:01 Initializing Terraform AWS Provider (SDKv2-style)...

--- PASS: TestAccELBV2TrustStore_Identity_RegionOverride (62.48s)
--- PASS: TestAccELBV2TrustStore_Identity_Basic (69.48s)
--- PASS: TestAccELBV2TrustStore_Identity_ExistingResource (81.12s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elbv2      87.032s
```
jar-b
jar-b approved these changes Jul 17, 2025
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=elbv2 TESTS=TestAccELBV2TrustStore_Identity
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccELBV2TrustStore_Identity'  -timeout 360m -vet=off
2025/07/17 15:44:01 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/17 15:44:01 Initializing Terraform AWS Provider (SDKv2-style)...

--- PASS: TestAccELBV2TrustStore_Identity_RegionOverride (62.48s)
--- PASS: TestAccELBV2TrustStore_Identity_Basic (69.48s)
--- PASS: TestAccELBV2TrustStore_Identity_ExistingResource (81.12s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elbv2      87.032s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdavison gdavison

@jar-b jar-b

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@breathingdust @gdavison @jar-b