Skip to content

🎂Tidy up and functionality support #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

🎂Tidy up and functionality support #5

wants to merge 11 commits into from

Conversation

ollieread
Copy link

I've removed all of the FQN docblocks that I added and only pushed in changes that haven't been made.

This includes;

  • Schema builder support
  • Some tidy up of the code
  • Some optimisation of the code
  • Some sanity checking
  • Implementation for whereRaw and whereColumn

Hope this is easier to review @jenssegers

I've remade this PR as it has been some time since it was originally created, so I'm going to continue to make modifications to the repository and release it as a composer package for immediate use. All changes that can be merged in here have been moved to the fork branch, but master will now diverge.

@jenssegers
Copy link
Owner

jenssegers commented Nov 17, 2018

Would it be possible to split up linting and functionality in different PR's?

@jenssegers jenssegers force-pushed the master branch 4 times, most recently from cd542d6 to 755a1bb Compare December 29, 2018 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants