This repository was archived by the owner on Sep 19, 2024. It is now read-only.
Fix warning for Xcode10.2 #31
Merged
+24
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 26, 2019 17:27
'public' modifier is redundant for instance method declared in a public extension
watanavex
commented
Mar 26, 2019
| @@ -1 +1 @@ | |||
| 3.0 | |||
| 4.0 | |||
There was a problem hiding this comment.
Same version as R. swift
I fixed warning, and
I checked compile (swift 4.0 and 5.0) with this visibility.
|
I opt to merge this PR 👍 |
|
Thanks for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I used R. swift with Xcode 10.2, I encountered many warnings.
All those warnings pointed to the same thing.
'public' modifier is redundant for instance method declared in a public extension