Skip to content
This repository was archived by the owner on Sep 19, 2024. It is now read-only.

UITableView dequeue header/footer view typo #6

Merged
merged 2 commits into from
Apr 18, 2016

Conversation

jmper1
Copy link
Contributor

@jmper1 jmper1 commented Apr 7, 2016

Fixes a typo that causes views of the correct superclass to not be dequeued as UITableView header/footer views

@mac-cain13
Copy link
Owner

Seems like this is indeed a typo! Thanks for the PR.

You change it to UIView here, but the documentation states that you should return a UITableViewHeaderFooterView from this method. Shouldn't we change it to UITableViewHeaderFooterView then?

@jmper1
Copy link
Contributor Author

jmper1 commented Apr 18, 2016

Yep, seems like the right thing to do. Is there a way to update an existing PR?

@mac-cain13
Copy link
Owner

Just push on the branch. (You can even force push if you want to overwrite the existing commit. 🤐)

@jmper1
Copy link
Contributor Author

jmper1 commented Apr 18, 2016

Hehe. Got it. Will do.

@jmper1
Copy link
Contributor Author

jmper1 commented Apr 18, 2016

There you go. Thanks for the help! :) Very awesome tool, by the way!

@mac-cain13
Copy link
Owner

Thanks for the PR!

@mac-cain13 mac-cain13 merged commit 7a75ee5 into mac-cain13:master Apr 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants