Skip to content

support symfony 3.0 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2015
Merged

support symfony 3.0 #18

merged 1 commit into from
Dec 3, 2015

Conversation

sc0rp10
Copy link
Contributor

@sc0rp10 sc0rp10 commented Dec 2, 2015

tests ran ok

@sc0rp10 sc0rp10 mentioned this pull request Dec 2, 2015
@mac-cain13
Copy link
Owner

Awesome thanks for using this and creating a PR!

I see Travis is complaining about PHP 5.4 and 5.3 because of your type signature change. Do you need to add the callable declaration or is this not needed perse? If not maybe you could revert that and then I can release it.

If it is needed I have to drop PHP 5.4 and 5.3 or find a workaround.

@sc0rp10
Copy link
Contributor Author

sc0rp10 commented Dec 2, 2015

Hey, @mac-cain13. As I see, Symfony 3.0 requires php >= 5.5.9 (https://github.com/symfony/symfony/blob/3.0/composer.json#L19) and can't be installed to container with 5.3/5.4
I don't see any other solutions except drop PHP 5.3/5.4 support, or drop symfony 3.0 support.

@mac-cain13
Copy link
Owner

Yeah, alright we should drop the older PHP versions!

mac-cain13 added a commit that referenced this pull request Dec 3, 2015
@mac-cain13 mac-cain13 merged commit 38fbccc into mac-cain13:master Dec 3, 2015
@sc0rp10
Copy link
Contributor Author

sc0rp10 commented Dec 3, 2015

👍

@mac-cain13
Copy link
Owner

This is now in the 1.3.0 release!

@abienvenu
Copy link

1.3.0 not only drops older PHP versions, but also older Symfony versions: 2.7 and 2.8 are incompatible with the new setCode() declaration.

@mac-cain13
Copy link
Owner

Arnaud is right about the breaking changes. They should be in a 2.0 with a clear notice that it's symfony 3 only and drops PHP versions.

I'll fix this later today. Sorry for the confusing you with not so semantic version numbers and breaking changes!

Op 10 dec. 2015 om 10:26 heeft Arnaud Bienvenu notifications@github.com het volgende geschreven:

1.3.0 not only drops older PHP versions, but also older Symfony versions: 2.7 and 2.8 are incompatible with the new setCode() declaration.


Reply to this email directly or view it on GitHub.

@Jean85 Jean85 mentioned this pull request Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants