-
Notifications
You must be signed in to change notification settings - Fork 39
support symfony 3.0 #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Awesome thanks for using this and creating a PR! I see Travis is complaining about PHP 5.4 and 5.3 because of your type signature change. Do you need to add the If it is needed I have to drop PHP 5.4 and 5.3 or find a workaround. |
Hey, @mac-cain13. As I see, Symfony 3.0 requires php >= 5.5.9 (https://github.com/symfony/symfony/blob/3.0/composer.json#L19) and can't be installed to container with 5.3/5.4 |
Yeah, alright we should drop the older PHP versions! |
👍 |
This is now in the 1.3.0 release! |
1.3.0 not only drops older PHP versions, but also older Symfony versions: 2.7 and 2.8 are incompatible with the new setCode() declaration. |
Arnaud is right about the breaking changes. They should be in a 2.0 with a clear notice that it's symfony 3 only and drops PHP versions. I'll fix this later today. Sorry for the confusing you with not so semantic version numbers and breaking changes!
|
tests ran ok