Skip to content

Update EndlessCommand.php #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

fmagnan
Copy link

@fmagnan fmagnan commented Dec 9, 2015

Hello,

thank you very much for your work, I use it and it works fine.
However, I want to upgrade my project dependencies and signature of method setCode is different between Wrep\Daemonizable\Command\EndlessCommand and Symfony\Component\Console\Command\Command

In symfony class, parameter $code is not typehint as callable, so I removed it here.
Is it good for you? Can you merge it to allow me to upgrade my dependencies?

Thanks in advance,

Hello,

thank you very much for your work, I use it and it works fine.
However, I want to upgrade my project dependencies and signature of method setCode is different between Wrep\Daemonizable\Command\EndlessCommand and Symfony\Component\Console\Command\Command

In symfony class, parameter $code is not typehint as callable, so I removed it here.
Is it good for you? Can you merge it to allow me to upgrade my dependencies?

Thanks in advance,
@abienvenu
Copy link

The 'callable' typehint has been added for Symfony 3.0 support. This breaks compatibility with Symfony 2.7. I am not sure this is intentional from @mac-cain13 to drop Symfony 2.7 with version 1.3 of daemonizable-command. This should require a 2.x version, or at least a big warning in the changelog.

@fmagnan
Copy link
Author

fmagnan commented Dec 10, 2015

Hello Arnaud,

thank you for your reply. I wanted to upgrade to symfony 2.8 with daemonizable-command in version 1.2 but composer fails to upgrade because of "callable" typehint. I thought I need to use newer version but it always fail. I don't know where is the problem but I think now it's in my project.

many thanks, have a good day!

@fmagnan fmagnan closed this Dec 10, 2015
@mac-cain13
Copy link
Owner

Arnaud is right about the breaking changes. They should be in a 2.0 with a clear notice that it's symfony 3 only and drops PHP versions.

I'll fix this later today. Sorry for the confusing you with not so semantic version numbers and breaking changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants