Removed calleable typehint.

[peter-hristov]

I did this because there's an if to check if it's callable anyway and more importantly when I tried to do composer update on my symfony2 project I got the following error:

Declaration of Wrep\Daemonizable\Command\EndlessCommand::setCode() should be compatible with Symfony\Component\Console\Command\Command::setCode($code)

[BPScott]

Ok, so...

Symfony 2.8 has no typehint - public function setCode($code) This is true for Symfony going all the way back to Symfony 2.2 (2.1 typehints on \Closure class).
Syfony 3.0 adds a callable typehint

This means that daemonizable-command can't support Symfony 2.[2 or more] and Symfony 3.0 with the same codebase.

@famouscake - this PR would break compatibility with Symfony 3. The fix is to work out if release 1.3 can be yanked from packagist, (as it is broken for people Symfony2) and release a new version that is 3.0 only. as @mac-cain13 has already mentioned.

@mac-cain13 It might be worth taking a look at setting up Travis to use composer's perfer-lowest hooks so CI can test with both the lowest and highest versions of allowable packages to make sure the dependancy ranges are right.

[mac-cain13]

Okay, so I screwed up with the version numbering and Symfony 3 support. I've fixed this with the following actions:

• Released 1.3.1, which is basically the same as the 1.2.6 release that is compatible with recent Symfony 2 releases and not with Symfony 3.
• Released 2.0.0, which supports Symfony 2.
• Updated the readme on what version to use.

This should make it all work again. Thanks for reporting the issue and taking the time to submit a PR!

[peter-hristov]

Works like a charm, Mathijs, thanks!

On 19 December 2015 at 15:06, Mathijs Kadijk notifications@github.com
wrote:

Closed #20 #20.

—
Reply to this email directly or view it on GitHub
#20 (comment)
.