Skip to content

Fixing Symfony ranges #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixing Symfony ranges #21

wants to merge 1 commit into from

Conversation

Jean85
Copy link
Contributor

@Jean85 Jean85 commented Dec 18, 2015

As in #20, the typehint in Wrep\Daemonizable\Command\EndlessCommand::setCode() makes this package compatible to SF3.0, but is a major BC for SF 2.*.

This PR is intended as a 2.0 of this package, and 1.3 version should be removed from packagist and untagged, since it's a semver violation.

This was also commented here: #18 (comment)

@mac-cain13
Copy link
Owner

Okay, so I screwed up with the version numbering and Symfony 3 support. I've fixed this with the following actions:

  • Released 1.3.1, which is basically the same as the 1.2.6 release that is compatible with recent Symfony 2 releases and not with Symfony 3.
  • Released 2.0.0, which supports Symfony 2.
  • Updated the readme on what version to use.

This should make it all work again. Thanks for reporting the issue and taking the time to submit a PR!

@mac-cain13 mac-cain13 closed this Dec 19, 2015
@Jean85
Copy link
Contributor Author

Jean85 commented Dec 19, 2015

Thanks @mac-cain13 !
I would suggest anyhow to remove the 1.3.0 tag from packagist (and from the repo, to avoid re-fetching), to avoid that anyone could install that version; it could happen with a ~1.3 composer requirement and SF2.

@mac-cain13
Copy link
Owner

Good suggestion @Jean85! Thanks, didn't realize I could remove it from packagist so easily. :)

It's removed now! Not from github atm, It was released and I think removing it from a git repo is not really good practice. But I think removing it from packagist is already good protection for people not paying attention.

@Jean85
Copy link
Contributor Author

Jean85 commented Dec 19, 2015

Watch out that a future automatic update from packagist could re-fetch the tag from GitHub. I'm not sure but I think you can easly remove it from the repo from the web interface; if not, you should do:

git tag -d 1.3.0
git push origin :refs/tags/1.3.0

@mac-cain13
Copy link
Owner

Good to know, I don't want to remove the tag completely since there might be people with Symfony 3 currently depending on it. That would suddenly break their setup.

If you use Symfony 2 it never worked anyway, so you probably downgraded or upgrade to the working version now.

It sucks to have a somewhat corrupt released version, but disappearing version numbers don't make it any better I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants