Fixed issue #32 #33
Closed
Fixed issue #32 #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
December 23, 2016 11:57
This reverts commit e5b1337.
|
Thanks for the PR. Could you please make separate PRs for separate improvements? It's very hard to review now because all lines are changed, and there are not only codestyle updates, but also docs and code changes. Also PSR-2 conformance and splitting up lines are not necessarily changes I want to merge without good reason. I think it would be good to explain the reason behind those changes before putting them in a PR. |
|
Well, the only reason would be PSR-2 compliance, but nevermind, I will send another PR just with the change regarding the issue. By the way, what coding standard do you use for the project? Symfony2? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also: