Skip to content

Add support for Symfony 7 given removal of ContainerAwareInterface #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pieterocp
Copy link
Contributor

Marking this as a draft since I'm not using the doctrine removal inside the project + might require some intermediary steps, e.g. a deprecation notice inside the library to make the upgrade path from 6.* -> 7.* easier.

@michnovka
Copy link
Contributor

I went over the Symfony 7 docs and source code of EndlessContainerAwareCommand.

I think we should get rid of this class. Symfony 7 forces us to use dependency injection inside constructor, so if somebody wants to work with doctrine, they should in fact inject EntityManager in their own constructor of the derived class. Then they can call doctrine->clear() if they want it (not every use case does).

I propose to just remove this class and add a mention of this and above steps to UPGRADE file. WDYT @mac-cain13 ?

@mac-cain13
Copy link
Owner

Thanks for the contibution @pieterocp, will merge the PR from @michnovka to get this update in.

@mac-cain13 mac-cain13 closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants