v5.0 - Symfony 7 support and refactoring #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michnovka
commented
Jun 19, 2024
There was a problem hiding this comment.
I have just one comment to be addressed, please have a look @mac-cain13
| @@ -212,22 +213,6 @@ private function getMemoryInfo(bool $peak = false): array | |||
| return $info; | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
@mac-cain13 I could not find any reason whatsoever to override the setCode function in our class. We call parent::setCode inside constructor. the code we execute is programmed in the derived classes inside its functions, which are called from the runloop. So why setCode is important? Also the function was copy of the parent function from Symfony 2, since Symfony 3 different code was used using Closure class. Yet another example why I think his was never used, thus the inconsistency never manifested as a bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup of old unused code. Bumped dependencies. Strict type all.