Skip to content

Commit 91cb6ec

Browse files
committed
Convert from page_action to browser_action
1 parent 693afd3 commit 91cb6ec

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

source/background.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,6 @@ chrome.tabs.onUpdated.addListener(function(tabId, changeInfo, tab)
4646
// Check if we have a match or don't need to match at all
4747
if ( (domain != null && match) || sites.length === 0)
4848
{
49-
// Show the pageAction
50-
chrome.pageAction.show(tabId);
51-
5249
// Request the current status and update the icon accordingly
5350
chrome.tabs.sendMessage(
5451
tabId,
@@ -155,13 +152,13 @@ function updateIcon(status, tabId)
155152
}
156153

157154
// Update title
158-
chrome.pageAction.setTitle({
155+
chrome.browserAction.setTitle({
159156
tabId: tabId,
160157
title: title
161158
});
162159

163160
// Update image
164-
chrome.pageAction.setIcon({
161+
chrome.browserAction.setIcon({
165162
tabId: tabId,
166163
path: image
167164
});

source/manifest.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
"options_page": "options.html",
1717

18-
"page_action": {
18+
"browser_action": {
1919
"default_icon": "images/bug-gray.png",
2020
"default_title": "Debugging, profiling & tracing disabled",
2121
"default_popup" : "popup.html"
@@ -30,7 +30,7 @@
3030
},
3131

3232
"commands": {
33-
"_execute_page_action": {
33+
"_execute_browser_action": {
3434
"suggested_key": {
3535
"default": "Ctrl+Shift+X",
3636
"windows": "Ctrl+Shift+X",

0 commit comments

Comments
 (0)