-
Notifications
You must be signed in to change notification settings - Fork 961
test(download): serialize tests with proxy-sensitive URLs #4372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Without this change, I could pretty reliably induce this race by narrowing the testsuite, so they're more likely to run in parallel.
Note that the |
@cuviper Thanks a lot for your investigation! This does look like one of the reasons why Rustup's CI is not as stable as expected. I'll have a look at your patch real soon :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Nit: Before merging, it'd be probably better to change the commit message to "all download tests" instead of just "all tests"... I know by "proxy-sensitive URLs" it implies download tests, but it looks a bit misleading at the first glance 💦 Many thanks in advance I decided to do that myself, never mind :)
There was already a guard for tests that *set* a proxy variable in the environment, but this is also relevant for tests that would implicitly read those variables while downloading a local `serve_file` URL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
There was already a guard for tests that set a proxy variable in the
environment, but this is also relevant for tests that would implicitly
read those variables while downloading a local
serve_file
URL.