Upgrade to rustls-platform-verifier 0.6 #4373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@djc Many thanks for the patch! I wish to have done this myself but looking at the changelog the migration path didn't seem extra obvious 🤔 PS: Oops, the diff is dirty so I cannot review it 🙏 |
djc
force-pushed
the
platform-verifier-0.6
branch
from
a27451d to
3cca450
Compare
|
Oops, not sure what happened there. Should be better now. |
djc
force-pushed
the
platform-verifier-0.6
branch
from
3cca450 to
4b99873
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a little involved because the
with_platform_verifier()call is now fallible, which means using aLazyLockwould be a little annoying/wasteful since we'd have to store aResultin it. Use aOnceLockinstead.The changes in rustls-platform-verifier 0.6 (which I created) were directly inspired by #4305, and should make rustup error out (earlier/at all) when no certificates can be found in the platform certificate store on Unix platforms that don't have their own platform verifier (like Linux, the BSDs, etc -- pretty much any Unix except Darwin-based platforms and Android).
Fixes #4305.