Fix: timeclock: allow overlapping sessions with same account name #2422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brymut
force-pushed
the
patch/timeclock-same-account-overlap
branch
2 times, most recently
from
8797d0e to
88f5c6b
Compare
|
Hi @simonmichael, made an attempt at #2417 here. |
brymut
force-pushed
the
patch/timeclock-same-account-overlap
branch
from
88f5c6b to
d1eefba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression that broke existing timeclock files containing overlapping sessions with the same account name. The issue was in
pairClockEntriesfunction which added a validation that prevented clock-in entries for accounts that already had active sessions.However, the existing
findInForOutlogic already had handling for multiple sessions with the same account name usingpartitionto correctly pair clock-ins with clock-outs.Closes #2417
Added test